From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different hardware settings Date: Mon, 23 May 2016 17:43:02 +0800 Message-ID: <1463996582.30093.5.camel@mtksdaap41> References: <1463756736-46573-1-git-send-email-yt.shen@mediatek.com> <1463756736-46573-4-git-send-email-yt.shen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1463756736-46573-4-git-send-email-yt.shen@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: yt.shen@mediatek.com Cc: Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Mao Huang , srv_heupstream@mediatek.com, Rob Herring , linux-mediatek@lists.infradead.org, Kumar Gala , Matthias Brugger , yingjoe.chen@mediatek.com, Sascha Hauer , linux-arm-kernel@lists.infradead.org List-Id: linux-mediatek@lists.infradead.org SGksIFlUOgoKT25lIGNvbW1lbnQgYmVsb3cuCgpPbiBGcmksIDIwMTYtMDUtMjAgYXQgMjM6MDUg KzA4MDAsIHl0LnNoZW5AbWVkaWF0ZWsuY29tIHdyb3RlOgo+IEZyb206IFlUIFNoZW4gPHl0LnNo ZW5AbWVkaWF0ZWsuY29tPgo+IAo+IFRoZXJlIGFyZSBzb21lIGhhcmR3YXJlIHNldHRpbmdzIGNo YW5nZWQsIGJldHdlZW4gTVQ4MTczICYgTVQyNzAxOgo+IERJU1BfT1ZMIGFkZHJlc3Mgb2Zmc2V0 IGNoYW5nZWQsIGNvbG9yIGZvcm1hdCBkZWZpbml0aW9uIGNoYW5nZWQuCj4gRElTUF9SRE1BIGZp Zm8gc2l6ZSBjaGFuZ2VkLgo+IERJU1BfQ09MT1Igb2Zmc2V0IGNoYW5nZWQuCj4gCj4gU2lnbmVk LW9mZi1ieTogWVQgU2hlbiA8eXQuc2hlbkBtZWRpYXRlay5jb20+Cj4gLS0tCj4gKwo+ICtzdGF0 aWMgaW5saW5lIHN0cnVjdCBtdGtfZGRwX2NvbXBfZHJpdmVyX2RhdGEgKm10a19vdmxfZ2V0X2Ry aXZlcl9kYXRhKAo+ICsJc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiArewo+ICsJY29u c3Qgc3RydWN0IG9mX2RldmljZV9pZCAqb2ZfaWQgPQo+ICsJCW9mX21hdGNoX2RldmljZShtdGtf ZGlzcF9vdmxfZHJpdmVyX2R0X21hdGNoLCAmcGRldi0+ZGV2KTsKPiArCj4gKwlyZXR1cm4gKHN0 cnVjdCBtdGtfZGRwX2NvbXBfZHJpdmVyX2RhdGEgKilvZl9pZC0+ZGF0YTsKPiArfQo+ICsKPiAr c3RhdGljIGlubGluZSBzdHJ1Y3QgbXRrX2RkcF9jb21wX2RyaXZlcl9kYXRhICptdGtfcmRtYV9n ZXRfZHJpdmVyX2RhdGEoCj4gKwlzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICt7Cj4g Kwljb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkICpvZl9pZCA9Cj4gKwkJb2ZfbWF0Y2hfZGV2aWNl KG10a19kaXNwX3JkbWFfZHJpdmVyX2R0X21hdGNoLCAmcGRldi0+ZGV2KTsKPiArCj4gKwlyZXR1 cm4gKHN0cnVjdCBtdGtfZGRwX2NvbXBfZHJpdmVyX2RhdGEgKilvZl9pZC0+ZGF0YTsKPiArfQo+ ICsKPiArc3RhdGljIGlubGluZSBzdHJ1Y3QgbXRrX2RkcF9jb21wX2RyaXZlcl9kYXRhICptdGtf Y29sb3JfZ2V0X2RyaXZlcl9kYXRhKAo+ICsJc3RydWN0IGRldmljZV9ub2RlICpub2RlKQo+ICt7 Cj4gKwljb25zdCBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkICpvZl9pZCA9Cj4gKwkJb2ZfbWF0Y2hfbm9k ZShtdGtfZGlzcF9jb2xvcl9kcml2ZXJfZHRfbWF0Y2gsIG5vZGUpOwo+ICsKPiArCXJldHVybiAo c3RydWN0IG10a19kZHBfY29tcF9kcml2ZXJfZGF0YSAqKW9mX2lkLT5kYXRhOwo+ICt9Cj4gKyAK ClRoZXNlIHRocmVlIGZ1bmN0aW9ucyBsb29rcyB0aGUgc2FtZSB3aXRoIGRpZmZlcmVudCBwYXJh bWV0ZXI6Cm10a19kaXNwX292bF9kcml2ZXJfZHRfbWF0Y2gsIG10a19kaXNwX3JkbWFfZHJpdmVy X2R0X21hdGNoLCBhbmQKbXRrX2Rpc3BfY29sb3JfZHJpdmVyX2R0X21hdGNoLiBTbyBtZXJnZSB0 aGVtIHRvIHByZXZlbnQgZHVwbGljYXRlZApjb2RlLgoKUmVnYXJkcywKQ0sKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: ck.hu@mediatek.com (CK Hu) Date: Mon, 23 May 2016 17:43:02 +0800 Subject: [RFC v2 3/5] drm/mediatek: add *driver_data for different hardware settings In-Reply-To: <1463756736-46573-4-git-send-email-yt.shen@mediatek.com> References: <1463756736-46573-1-git-send-email-yt.shen@mediatek.com> <1463756736-46573-4-git-send-email-yt.shen@mediatek.com> Message-ID: <1463996582.30093.5.camel@mtksdaap41> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, YT: One comment below. On Fri, 2016-05-20 at 23:05 +0800, yt.shen at mediatek.com wrote: > From: YT Shen > > There are some hardware settings changed, between MT8173 & MT2701: > DISP_OVL address offset changed, color format definition changed. > DISP_RDMA fifo size changed. > DISP_COLOR offset changed. > > Signed-off-by: YT Shen > --- > + > +static inline struct mtk_ddp_comp_driver_data *mtk_ovl_get_driver_data( > + struct platform_device *pdev) > +{ > + const struct of_device_id *of_id = > + of_match_device(mtk_disp_ovl_driver_dt_match, &pdev->dev); > + > + return (struct mtk_ddp_comp_driver_data *)of_id->data; > +} > + > +static inline struct mtk_ddp_comp_driver_data *mtk_rdma_get_driver_data( > + struct platform_device *pdev) > +{ > + const struct of_device_id *of_id = > + of_match_device(mtk_disp_rdma_driver_dt_match, &pdev->dev); > + > + return (struct mtk_ddp_comp_driver_data *)of_id->data; > +} > + > +static inline struct mtk_ddp_comp_driver_data *mtk_color_get_driver_data( > + struct device_node *node) > +{ > + const struct of_device_id *of_id = > + of_match_node(mtk_disp_color_driver_dt_match, node); > + > + return (struct mtk_ddp_comp_driver_data *)of_id->data; > +} > + These three functions looks the same with different parameter: mtk_disp_ovl_driver_dt_match, mtk_disp_rdma_driver_dt_match, and mtk_disp_color_driver_dt_match. So merge them to prevent duplicated code. Regards, CK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbcEWJnK (ORCPT ); Mon, 23 May 2016 05:43:10 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:44663 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752335AbcEWJnI (ORCPT ); Mon, 23 May 2016 05:43:08 -0400 Message-ID: <1463996582.30093.5.camel@mtksdaap41> Subject: Re: [RFC v2 3/5] drm/mediatek: add *driver_data for different hardware settings From: CK Hu To: CC: , Philipp Zabel , Rob Herring , Pawel Moll , "Mark Rutland" , Ian Campbell , Kumar Gala , "Russell King" , David Airlie , "Matthias Brugger" , Mao Huang , "Bibby Hsieh" , , , , , , "Sascha Hauer" , , Date: Mon, 23 May 2016 17:43:02 +0800 In-Reply-To: <1463756736-46573-4-git-send-email-yt.shen@mediatek.com> References: <1463756736-46573-1-git-send-email-yt.shen@mediatek.com> <1463756736-46573-4-git-send-email-yt.shen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, YT: One comment below. On Fri, 2016-05-20 at 23:05 +0800, yt.shen@mediatek.com wrote: > From: YT Shen > > There are some hardware settings changed, between MT8173 & MT2701: > DISP_OVL address offset changed, color format definition changed. > DISP_RDMA fifo size changed. > DISP_COLOR offset changed. > > Signed-off-by: YT Shen > --- > + > +static inline struct mtk_ddp_comp_driver_data *mtk_ovl_get_driver_data( > + struct platform_device *pdev) > +{ > + const struct of_device_id *of_id = > + of_match_device(mtk_disp_ovl_driver_dt_match, &pdev->dev); > + > + return (struct mtk_ddp_comp_driver_data *)of_id->data; > +} > + > +static inline struct mtk_ddp_comp_driver_data *mtk_rdma_get_driver_data( > + struct platform_device *pdev) > +{ > + const struct of_device_id *of_id = > + of_match_device(mtk_disp_rdma_driver_dt_match, &pdev->dev); > + > + return (struct mtk_ddp_comp_driver_data *)of_id->data; > +} > + > +static inline struct mtk_ddp_comp_driver_data *mtk_color_get_driver_data( > + struct device_node *node) > +{ > + const struct of_device_id *of_id = > + of_match_node(mtk_disp_color_driver_dt_match, node); > + > + return (struct mtk_ddp_comp_driver_data *)of_id->data; > +} > + These three functions looks the same with different parameter: mtk_disp_ovl_driver_dt_match, mtk_disp_rdma_driver_dt_match, and mtk_disp_color_driver_dt_match. So merge them to prevent duplicated code. Regards, CK