From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49183)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b4qHw-0004ws-MH
	for qemu-devel@nongnu.org; Mon, 23 May 2016 09:52:57 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b4qHr-0002x0-L9
	for qemu-devel@nongnu.org; Mon, 23 May 2016 09:52:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34897)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b4qHr-0002wt-GC
	for qemu-devel@nongnu.org; Mon, 23 May 2016 09:52:51 -0400
Message-ID: <1464011569.29367.27.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 23 May 2016 15:52:49 +0200
In-Reply-To: <CAJ+F1CJepo4LJw2_Re1EEEJFvidQWuZ8JSy6-GaiGnGY9uL5ng@mail.gmail.com>
References: <1455873289-349-1-git-send-email-kraxel@redhat.com>
	<1455873289-349-11-git-send-email-kraxel@redhat.com>
	<1458307049.6882.54.camel@redhat.com>
	<CAJ+F1CLoMGE22+X5ACdDDooo+7Y+FjxK7PE+u-Z4RcDd++-CEA@mail.gmail.com>
	<1458555845.4299.49.camel@redhat.com>
	<CAJ+F1CJepo4LJw2_Re1EEEJFvidQWuZ8JSy6-GaiGnGY9uL5ng@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 10/12] spice/gl: create dummy primary
 surface (RfC)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>
Cc: spice-devel <spice-devel@lists.freedesktop.org>, QEMU <qemu-devel@nongnu.org>

  Hi,

Resuming to work on this after 2.6 freeze break ...

> I have done some more testing and sent a series for spice-gtk fixing
> display with gl scanout-only case. And a minor patch to spice server
> to solve a cursor initialization when there is no canvas. Your series
> works ok with that, only when doing a reboot, virtio_gpu_virgl_reset()
> calls spice_qxl_gl_scanout( fd =3D -1), and later spice_gl_refresh()
> calls spice_qxl_gl_draw_async() and reaches the following error:
>=20
> (process:21117): Spice-CRITICAL **:
> red-qxl.c:900:spice_qxl_gl_draw_async: condition
> `qxl_state->scanout.drm_dma_buf_fd !=3D -1' failed

Hmm, that is sort-of intentional.  It's valid for scanouts to not be
backed by a resource, and in that case qemu_spice_gl_scanout() calls
spice_qxl_gl_scanout() with fd=3D-1.

So, what do you think we should do here?  Fix spice to handle that case?
Should qemu do something else instead?  Such as not calling
spice_qxl_gl_scanout() to keep the previous dma-buf alive?

cheers,
  Gerd