All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Michal Hocko <mhocko@kernel.org>,
	Ebru Akagunduz <ebru.akagunduz@gmail.com>
Cc: linux-mm@kvack.org, hughd@google.com, akpm@linux-foundation.org,
	kirill.shutemov@linux.intel.com, n-horiguchi@ah.jp.nec.com,
	aarcange@redhat.com, iamjoonsoo.kim@lge.com, gorcunov@openvz.org,
	linux-kernel@vger.kernel.org, mgorman@suse.de,
	rientjes@google.com, vbabka@suse.cz,
	aneesh.kumar@linux.vnet.ibm.com, hannes@cmpxchg.org,
	boaz@plexistor.com
Subject: Re: [PATCH 3/3] mm, thp: make swapin readahead under down_read of mmap_sem
Date: Mon, 23 May 2016 14:49:09 -0400	[thread overview]
Message-ID: <1464029349.16365.58.camel@redhat.com> (raw)
In-Reply-To: <20160523184246.GE32715@dhcp22.suse.cz>

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

On Mon, 2016-05-23 at 20:42 +0200, Michal Hocko wrote:
> On Mon 23-05-16 20:14:11, Ebru Akagunduz wrote:
> > 
> > Currently khugepaged makes swapin readahead under
> > down_write. This patch supplies to make swapin
> > readahead under down_read instead of down_write.
> You are still keeping down_write. Can we do without it altogether?
> Blocking mmap_sem of a remote proces for write is certainly not nice.

Maybe Andrea can explain why khugepaged requires
a down_write of mmap_sem?

If it were possible to have just down_read that
would make the code a lot simpler.

-- 
All Rights Reversed.


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-05-23 18:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-23 17:14 [PATCH 0/3] mm, thp: remove duplication and fix locking issues in swapin Ebru Akagunduz
2016-05-23 17:14 ` Ebru Akagunduz
2016-05-23 17:14 ` [PATCH 1/3] mm, thp: remove duplication of included header Ebru Akagunduz
2016-05-23 17:14   ` Ebru Akagunduz
2016-05-23 17:14 ` [PATCH 2/3] mm, thp: fix possible circular locking dependency caused by sum_vm_event() Ebru Akagunduz
2016-05-23 17:14   ` Ebru Akagunduz
2016-05-23 17:14 ` [PATCH 3/3] mm, thp: make swapin readahead under down_read of mmap_sem Ebru Akagunduz
2016-05-23 17:14   ` Ebru Akagunduz
2016-05-23 17:44   ` Kirill A. Shutemov
2016-05-23 17:44     ` Kirill A. Shutemov
2016-05-23 18:42   ` Michal Hocko
2016-05-23 18:42     ` Michal Hocko
2016-05-23 18:49     ` Rik van Riel [this message]
2016-05-23 19:01       ` Kirill A. Shutemov
2016-05-23 19:01         ` Kirill A. Shutemov
2016-05-23 19:26         ` Rik van Riel
2016-05-23 20:02           ` Kirill A. Shutemov
2016-05-23 20:02             ` Kirill A. Shutemov
2016-05-23 20:13             ` Rik van Riel
2016-05-23 21:49               ` Kirill A. Shutemov
2016-05-23 21:49                 ` Kirill A. Shutemov
2016-05-23 23:08                 ` Andrea Arcangeli
2016-05-23 23:08                   ` Andrea Arcangeli
2016-05-23 17:29 ` [PATCH 0/3] mm, thp: remove duplication and fix locking issues in swapin Ebru Akagunduz
2016-05-23 17:29   ` Ebru Akagunduz
2016-05-27 13:12   ` Michal Hocko
2016-05-27 13:12     ` Michal Hocko
2016-06-11 19:21     ` Ebru Akagunduz
2016-06-11 19:21       ` Ebru Akagunduz
2016-06-13 13:55       ` Michal Hocko
2016-06-13 13:55         ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464029349.16365.58.camel@redhat.com \
    --to=riel@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=boaz@plexistor.com \
    --cc=ebru.akagunduz@gmail.com \
    --cc=gorcunov@openvz.org \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@kernel.org \
    --cc=n-horiguchi@ah.jp.nec.com \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.