From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH] drm/dp/mst: Always clear proposed vcpi table for port. Date: Tue, 24 May 2016 11:00:53 -0400 Message-ID: <1464102053.18942.0.camel@redhat.com> References: <1463714317-14392-1-git-send-email-Andrey.Grodzovsky@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1463714317-14392-1-git-send-email-Andrey.Grodzovsky@amd.com> Sender: stable-owner@vger.kernel.org To: Andrey Grodzovsky , dri-devel@lists.freedesktop.org Cc: Alexander.Deucher@amd.com, Mykola.Lysenko@amd.com, stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Looks good to me. Reviewed-by: Lyude On Thu, 2016-05-19 at 23:18 -0400, Andrey Grodzovsky wrote: > Not clearing mst manager's proposed vcpis table for destroyed > connectors when the manager is stopped leaves it pointing to > unrefernced memory, this causes pagefault when the manager is > restarted when plugging back a branch. >=20 > Signed-off-by: Andrey Grodzovsky > --- > =C2=A0drivers/gpu/drm/drm_dp_mst_topology.c | 8 +++----- > =C2=A01 file changed, 3 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c > b/drivers/gpu/drm/drm_dp_mst_topology.c > index 9971c46..cd6014b 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -2881,11 +2881,9 @@ static void drm_dp_destroy_connector_work(stru= ct > work_struct *work) > =C2=A0 drm_dp_port_teardown_pdt(port, port->pdt); > =C2=A0 > =C2=A0 if (!port->input && port->vcpi.vcpi > 0) { > - if (mgr->mst_state) { > - drm_dp_mst_reset_vcpi_slots(mgr, port); > - drm_dp_update_payload_part1(mgr); > - drm_dp_mst_put_payload_id(mgr, port- > >vcpi.vcpi); > - } > + drm_dp_mst_reset_vcpi_slots(mgr, port); > + drm_dp_update_payload_part1(mgr); > + drm_dp_mst_put_payload_id(mgr, port->vcpi.vcpi); > =C2=A0 } > =C2=A0 > =C2=A0 kref_put(&port->kref, drm_dp_free_mst_port);