diff for duplicates of <1464285174.4578.36.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 3177949..bce6781 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ Hi Elad, -On Thu, 2016-05-26@15:00 +0300, Elad Kanfi wrote: -> From: Elad Kanfi <eladkan at mellanox.com> +On Thu, 2016-05-26 at 15:00 +0300, Elad Kanfi wrote: +> From: Elad Kanfi <eladkan@mellanox.com> > > Since NAPI works by shutting down event interrupts when theres > work and turning them on when theres none, the net driver must @@ -11,44 +11,44 @@ On Thu, 2016-05-26@15:00 +0300, Elad Kanfi wrote: > Any received packets will be handled in nps_enet_poll by polling the HW > indication of received packet until all packets are handled. > -> Signed-off-by: Elad Kanfi <eladkan at mellanox.com> -> Acked-by: Noam Camus <noamca at mellanox.com> +> Signed-off-by: Elad Kanfi <eladkan@mellanox.com> +> Acked-by: Noam Camus <noamca@mellanox.com> > --- -> ?drivers/net/ethernet/ezchip/nps_enet.c |????4 +++- -> ?1 files changed, 3 insertions(+), 1 deletions(-) +> drivers/net/ethernet/ezchip/nps_enet.c | 4 +++- +> 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c > index 085f912..06f0317 100644 > --- a/drivers/net/ethernet/ezchip/nps_enet.c > +++ b/drivers/net/ethernet/ezchip/nps_enet.c > @@ -205,8 +205,10 @@ static int nps_enet_poll(struct napi_struct *napi, int budget) -> ? ?* re-adding ourselves to the poll list. -> ? ?*/ -> ? +> * re-adding ourselves to the poll list. +> */ +> > - if (priv->tx_skb && !tx_ctrl_ct) > + if (priv->tx_skb && !tx_ctrl_ct) { > + nps_enet_reg_set(priv, NPS_ENET_REG_BUF_INT_ENABLE, 0); -> ? napi_reschedule(napi); +> napi_reschedule(napi); > + } -> ? } -> ? -> ? return work_done; +> } +> +> return work_done; We just bumped into the same problem (data exchange hangs on the very first "ping") with released Linux v4.6 and linux-next on our nSIM OSCI virtual platform. -I believe it was commit?05c00d82f4d1 ("net: nps_enet: bug fix - handle lost tx interrupts") +I believe it was commit 05c00d82f4d1 ("net: nps_enet: bug fix - handle lost tx interrupts") that introduced the problem. At least reverting it I got networking working. And indeed that patch fixes mentioned issue. In other words... -Tested-by: Alexey Brodkin <abrodkin at synopsys.com> +Tested-by: Alexey Brodkin <abrodkin@synopsys.com> P.S. Given my observation is correct please add following to your commit message if you ever do a respin: ------------------>8--------------- Fixes: 05c00d82f4d1 ("net: nps_enet: bug fix - handle lost tx interrupts") -Cc: <stable at vger.kernel.org> # 4.6.x +Cc: <stable@vger.kernel.org> # 4.6.x ------------------>8--------------- diff --git a/a/content_digest b/N1/content_digest index 99aad0f..9b16f16 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,20 @@ "ref\01464264006-26627-1-git-send-email-eladkan@mellanox.com\0" - "From\0Alexey.Brodkin@synopsys.com (Alexey Brodkin)\0" - "Subject\0[PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule\0" + "From\0Alexey Brodkin <Alexey.Brodkin@synopsys.com>\0" + "Subject\0Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule\0" "Date\0Thu, 26 May 2016 17:53:29 +0000\0" - "To\0linux-snps-arc@lists.infradead.org\0" + "To\0eladkan@mellanox.com <eladkan@mellanox.com>\0" + "Cc\0linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org>" + linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> + netdev@vger.kernel.org <netdev@vger.kernel.org> + noamca@mellanox.com <noamca@mellanox.com> + Anton Kolesov <Anton.Kolesov@synopsys.com> + " davem@davemloft.net <davem@davemloft.net>\0" "\00:1\0" "b\0" "Hi Elad,\n" "\n" - "On Thu, 2016-05-26@15:00 +0300, Elad Kanfi wrote:\n" - "> From: Elad Kanfi <eladkan at mellanox.com>\n" + "On Thu, 2016-05-26 at 15:00 +0300, Elad Kanfi wrote:\n" + "> From: Elad Kanfi <eladkan@mellanox.com>\n" "> \n" "> Since NAPI works by shutting down event interrupts when theres\n" "> work and turning them on when theres none, the net driver must\n" @@ -18,46 +24,46 @@ "> Any received packets will be handled in nps_enet_poll by polling the HW\n" "> indication of received packet until all packets are handled.\n" "> \n" - "> Signed-off-by: Elad Kanfi <eladkan at mellanox.com>\n" - "> Acked-by: Noam Camus <noamca at mellanox.com>\n" + "> Signed-off-by: Elad Kanfi <eladkan@mellanox.com>\n" + "> Acked-by: Noam Camus <noamca@mellanox.com>\n" "> ---\n" - "> ?drivers/net/ethernet/ezchip/nps_enet.c |????4 +++-\n" - "> ?1 files changed, 3 insertions(+), 1 deletions(-)\n" + "> \302\240drivers/net/ethernet/ezchip/nps_enet.c |\302\240\302\240\302\240\302\2404 +++-\n" + "> \302\2401 files changed, 3 insertions(+), 1 deletions(-)\n" "> \n" "> diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c\n" "> index 085f912..06f0317 100644\n" "> --- a/drivers/net/ethernet/ezchip/nps_enet.c\n" "> +++ b/drivers/net/ethernet/ezchip/nps_enet.c\n" "> @@ -205,8 +205,10 @@ static int nps_enet_poll(struct napi_struct *napi, int budget)\n" - "> ?\t\t?* re-adding ourselves to the poll list.\n" - "> ?\t\t?*/\n" - "> ?\n" + "> \302\240\t\t\302\240* re-adding ourselves to the poll list.\n" + "> \302\240\t\t\302\240*/\n" + "> \302\240\n" "> -\t\tif (priv->tx_skb && !tx_ctrl_ct)\n" "> +\t\tif (priv->tx_skb && !tx_ctrl_ct) {\n" "> +\t\t\tnps_enet_reg_set(priv, NPS_ENET_REG_BUF_INT_ENABLE, 0);\n" - "> ?\t\t\tnapi_reschedule(napi);\n" + "> \302\240\t\t\tnapi_reschedule(napi);\n" "> +\t\t}\n" - "> ?\t}\n" - "> ?\n" - "> ?\treturn work_done;\n" + "> \302\240\t}\n" + "> \302\240\n" + "> \302\240\treturn work_done;\n" "\n" "We just bumped into the same problem (data exchange hangs on the very first \"ping\")\n" "with released Linux v4.6 and linux-next on our nSIM OSCI virtual platform.\n" "\n" - "I believe it was commit?05c00d82f4d1 (\"net: nps_enet: bug fix - handle lost tx interrupts\")\n" + "I believe it was commit\302\24005c00d82f4d1 (\"net: nps_enet: bug fix - handle lost tx interrupts\")\n" "that introduced the problem. At least reverting it I got networking working.\n" "\n" "And indeed that patch fixes mentioned issue.\n" "In other words...\n" "\n" - "Tested-by: Alexey Brodkin <abrodkin at synopsys.com>\n" + "Tested-by: Alexey Brodkin <abrodkin@synopsys.com>\n" "\n" "P.S. Given my observation is correct please add following to your commit\n" "message if you ever do a respin:\n" "------------------>8---------------\n" "Fixes: 05c00d82f4d1 (\"net: nps_enet: bug fix - handle lost tx interrupts\")\n" "\n" - "Cc: <stable at vger.kernel.org> # 4.6.x\n" + "Cc: <stable@vger.kernel.org> # 4.6.x\n" ------------------>8--------------- -5da82ecb68f3b335e0df26061d31f24ee1d9a4d939c3b27a55a0a8403fd24d86 +59fb48d18bfd526c9bcdd3b544d6301a5131fe4ea5b57f56258911e9f152f391
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.