From: Peng Fan <van.freenix@gmail.com>
To: julien.grall@arm.com, sstabellini@kernel.org
Cc: van.freenix@gmail.com, xen-devel@lists.xen.org
Subject: [PATCH] xen/arm64: config: correct VMAP_VIRT_END
Date: Fri, 27 May 2016 18:23:10 +0800 [thread overview]
Message-ID: <1464344590-12093-1-git-send-email-van.freenix@gmail.com> (raw)
To ARM64, we should use '(VMAP_VIRT_START + GB(1))' as VMAP_VIRT_END,
but not '(VMAP_VIRT_START + GB(1) - 1)'.
Seeing 'vm_end[type] = PFN_DOWN(end - start);' in vm_init_type,
if not correct VMAP_VIRT_END, one page is wasted.
Signed-off-by: Peng Fan <van.freenix@gmail.com>
Cc: Julien Grall <julien.grall@arm.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>
---
I found X86 use '(VMAP_VIRT_START + GB(64))' and ARM32 use XENHEAP_VIRT_START,
both are aligned address. So, I think ARM64 may also need to use aligned
address. I am not very sure (:
xen/include/asm-arm/config.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/include/asm-arm/config.h b/xen/include/asm-arm/config.h
index 2d11b62..f92c0a0 100644
--- a/xen/include/asm-arm/config.h
+++ b/xen/include/asm-arm/config.h
@@ -147,7 +147,7 @@
#define SLOT0_ENTRY_SIZE SLOT0(1)
#define VMAP_VIRT_START GB(1)
-#define VMAP_VIRT_END (VMAP_VIRT_START + GB(1) - 1)
+#define VMAP_VIRT_END (VMAP_VIRT_START + GB(1))
#define FRAMETABLE_VIRT_START GB(32)
#define FRAMETABLE_SIZE GB(32)
--
2.6.2
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-05-27 10:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 10:23 Peng Fan [this message]
2016-05-31 11:07 ` [PATCH] xen/arm64: config: correct VMAP_VIRT_END Julien Grall
2016-06-01 7:24 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464344590-12093-1-git-send-email-van.freenix@gmail.com \
--to=van.freenix@gmail.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.