Re: [PATCH] bitbake.conf: add default for IMAGE_FSTYPES_DEBUGFS

["André Draszik" <git@andred.net>]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

This doesn't work for me (at least on krogoth):

    ERROR: poky/meta/recipes-core/images/build-appliance-image_14.0.0.bb: No IMAGE_CMD defined for IMAGE_FSTYPES entry 'debugfs_vmdk' - possibly invalid type name or missing support class
    ERROR: Failed to parse recipe: poky/meta/recipes-core/images/build-appliance-image_14.0.0.bb

I *instead* am using the attached patch successfully.

Is anybody else facing the same issue?


On Fr, 2016-05-06 at 12:26 +0100, Ross Burton wrote:
> If debug filesystem generation is enabled but this isn't assigned then the
> generation code throws exceptions.
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/conf/bitbake.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index 1c4175f..8e02e91 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -713,6 +713,7 @@ require conf/sanity.conf
>  DL_DIR ?= "${TOPDIR}/downloads"
>  SSTATE_DIR ?= "${TOPDIR}/sstate-cache"
>  IMAGE_FSTYPES ?= "tar.gz"
> +IMAGE_FSTYPES_DEBUGFS ?= "${IMAGE_FSTYPES}"
>  
>  INITRAMFS_FSTYPES ?= "cpio.gz"
>  # The maximum size in Kbytes for the generated initramfs image size.
> -- 
> 2.8.0.rc3
> 

[-- Attachment #2: 0001-image.bbclass-allow-IMAGE_FSTYPES_DEBUGFS-to-be-unse.patch --]
[-- Type: text/x-patch, Size: 2157 bytes --]

From 001ab66c36b18b8a3f25b1116a8c6580c676a673 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Draszik?= <git@andred.net>
Date: Tue, 12 Apr 2016 09:14:40 +0100
Subject: [PATCH] image.bbclass: allow IMAGE_FSTYPES_DEBUGFS to be unset (as
 per the documentation)

conf/local.conf.sample.extended describes IMAGE_FSTYPES_DEBUGFS as defaulting
to IMAGE_FSTYPES if unset.

If you actually do that, i.e. enable IMAGE_GEN_DEBUGFS but don't set
IMAGE_FSTYPES_DEBUGFS, you get the following parse error:

ERROR: Error executing a python function in <code>:

The stack trace of python calls that resulted in this exception/failure was:
File: '<code>', lineno: 14, function: <module>
     0010:__anon_38__meta_classes_rootfs_ipk_bbclass(d)
     0011:__anon_113__meta_classes_image_bbclass(d)
     0012:__anon_176__meta_classes_image_bbclass(d)
     0013:__anon_146__meta_classes_siteinfo_bbclass(d)
 *** 0014:__anon_437__meta_classes_image_bbclass(d)
File: '<poky>meta/classes/image.bbclass', lineno: 322, function: __anon_437__meta_classes_image_bbclass
     0318:    typedeps = {}
     0319:
     0320:    if d.getVar('IMAGE_GEN_DEBUGFS', True) == "1":
     0321:        debugfs_fstypes = d.getVar('IMAGE_FSTYPES_DEBUGFS', True).split()
 *** 0322:        for t in debugfs_fstypes:
     0323:            alltypes.append("debugfs_" + t)
     0324:
     0325:    def _add_type(t):
     0326:        baset = _image_base_type(t)
Exception: AttributeError: 'NoneType' object has no attribute 'split'
---
 meta/classes/image.bbclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index acaa9ec..59ba38e 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -318,8 +318,8 @@ python () {
     typedeps = {}
 
     if d.getVar('IMAGE_GEN_DEBUGFS', True) == "1":
-        debugfs_fstypes = d.getVar('IMAGE_FSTYPES_DEBUGFS', True).split()
-        for t in debugfs_fstypes:
+        debugfs_fstypes = d.getVar('IMAGE_FSTYPES_DEBUGFS', True) or ''
+        for t in debugfs_fstypes.split():
             alltypes.append("debugfs_" + t)
 
     def _add_type(t):
-- 
2.8.1