From: Shanker Donthineni <shankerd@codeaurora.org>
To: xen-devel <xen-devel@lists.xensource.com>
Cc: Philip Elcan <pelcan@codeaurora.org>,
Julien Grall <julien.grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Shanker Donthineni <shankerd@codeaurora.org>,
Vikram Sethi <vikrams@codeaurora.org>
Subject: [PATCH v2] arm/gic-v3: Fix ACPI probe fail on GICv4 hardware
Date: Fri, 27 May 2016 10:00:56 -0500 [thread overview]
Message-ID: <1464361256-28713-1-git-send-email-shankerd@codeaurora.org> (raw)
The current driver ACPI probe fails on hardware which has GICv4
version, even though it is fully compatible to GICv3. This patch
fixes the issue by registering the same probe function for GICv4
hardware.
Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
---
Changes since v1:
- Edit commit text.
- Fix BUG() in xen/arch/arm/domain.c
This patch tested on Qualcomm Technologies on QDF2XXX platforms.
xen/arch/arm/domain.c | 5 +++++
xen/arch/arm/gic-v3.c | 13 +++++++++++++
xen/include/asm-arm/gic.h | 1 +
3 files changed, 19 insertions(+)
diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c
index 1365b4a..5647b80 100644
--- a/xen/arch/arm/domain.c
+++ b/xen/arch/arm/domain.c
@@ -571,6 +571,11 @@ int arch_domain_create(struct domain *d, unsigned int domcr_flags,
d->arch.vgic.version = GIC_V3;
break;
+ case GIC_V4:
+ config->gic_version = XEN_DOMCTL_CONFIG_GIC_V3;
+ d->arch.vgic.version = GIC_V3;
+ break;
+
default:
BUG();
}
diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c
index a095064..594cf6e 100644
--- a/xen/arch/arm/gic-v3.c
+++ b/xen/arch/arm/gic-v3.c
@@ -1604,10 +1604,23 @@ static int __init gicv3_acpi_preinit(const void *data)
return 0;
}
+static int __init gicv4_acpi_preinit(const void *data)
+{
+ gicv3_info.hw_version = GIC_V4;
+ register_gic_ops(&gicv3_ops);
+
+ return 0;
+}
+
ACPI_DEVICE_START(agicv3, "GICv3", DEVICE_GIC)
.class_type = ACPI_MADT_GIC_VERSION_V3,
.init = gicv3_acpi_preinit,
ACPI_DEVICE_END
+
+ACPI_DEVICE_START(agicv4, "GICv4", DEVICE_GIC)
+ .class_type = ACPI_MADT_GIC_VERSION_V4,
+ .init = gicv4_acpi_preinit,
+ACPI_DEVICE_END
#endif
/*
diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
index cd97bb2..5be814a 100644
--- a/xen/include/asm-arm/gic.h
+++ b/xen/include/asm-arm/gic.h
@@ -218,6 +218,7 @@ struct gic_lr {
enum gic_version {
GIC_V2,
GIC_V3,
+ GIC_V4,
};
extern enum gic_version gic_hw_version(void);
--
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next reply other threads:[~2016-05-27 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 15:00 Shanker Donthineni [this message]
2016-05-27 15:10 ` [PATCH v2] arm/gic-v3: Fix ACPI probe fail on GICv4 hardware Julien Grall
2016-05-27 15:30 ` Shanker Donthineni
2016-05-27 16:10 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464361256-28713-1-git-send-email-shankerd@codeaurora.org \
--to=shankerd@codeaurora.org \
--cc=julien.grall@arm.com \
--cc=pelcan@codeaurora.org \
--cc=sstabellini@kernel.org \
--cc=vikrams@codeaurora.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.