From: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: linux-mips@linux-mips.org, hauke@hauke-m.de, jogo@openwrt.org,
openwrt@kresin.me
Subject: Re: [PATCH v2] Re: Adding support for device tree and command line
Date: Sat, 28 May 2016 18:23:40 -0700 [thread overview]
Message-ID: <1464485020.5020.28.camel@chimera> (raw)
In-Reply-To: <1464462306.5020.25.camel@chimera>
On Sat, 2016-05-28 at 12:05 -0700, Daniel Gimpelevich wrote:
> On Sat, 2016-05-28 at 13:31 +0300, Antony Pavlov wrote:
> > Can we use 'if' instead of preprocessor's '#if' here?
> >
> > If we use regular C 'if' operator with IS_ENABLED() instead of
> > '#if/#ifdef'
> > then the compiler can check all the code.
> >
> > E.g. please see this barebox patch:
> >
> >
> > http://lists.infradead.org/pipermail/barebox/2014-February/017834.html
>
> Sigh. I guess I will resubmit again…
Upon further review, no, we cannot use 'if' instead of '#if' here. The
reference to the appended DTB would throw a linker error if the option
to put it there is not enabled. Sorry.
next prev parent reply other threads:[~2016-05-29 1:23 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 21:14 Adding support for device tree and command line Hauke Mehrtens
2016-05-23 21:34 ` Hauke Mehrtens
2016-05-23 22:12 ` Daniel Gimpelevich
2016-05-24 5:32 ` [RFC PATCH] " Daniel Gimpelevich
2016-05-24 11:27 ` Antony Pavlov
2016-05-24 15:15 ` Daniel Gimpelevich
2016-05-24 15:27 ` Daniel Gimpelevich
2016-05-24 16:48 ` Antony Pavlov
2016-05-24 17:00 ` Daniel Gimpelevich
2016-05-25 3:31 ` Antony Pavlov
2016-05-25 3:33 ` Daniel Gimpelevich
2016-05-27 21:06 ` [PATCH v2] " Daniel Gimpelevich
2016-05-28 10:31 ` Antony Pavlov
2016-05-28 19:05 ` Daniel Gimpelevich
2016-05-29 1:23 ` Daniel Gimpelevich [this message]
2016-05-30 17:24 ` Antony Pavlov
2016-05-29 10:53 ` Jonas Gorski
2016-05-29 18:38 ` Daniel Gimpelevich
2016-05-29 19:01 ` Jonas Gorski
2016-05-29 19:08 ` Daniel Gimpelevich
2016-05-29 19:22 ` Jonas Gorski
2016-05-29 19:26 ` Daniel Gimpelevich
2016-05-29 19:30 ` Jonas Gorski
2016-05-29 21:19 ` Daniel Gimpelevich
2016-05-26 16:25 ` [RFC PATCH] " Hauke Mehrtens
2016-05-26 17:24 ` Daniel Gimpelevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464485020.5020.28.camel@chimera \
--to=daniel@gimpelevich.san-francisco.ca.us \
--cc=antonynpavlov@gmail.com \
--cc=hauke@hauke-m.de \
--cc=jogo@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=openwrt@kresin.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.