diff for duplicates of <1464640622.19317.54.camel@intel.com> diff --git a/a/1.txt b/N1/1.txt index 48af076..031203c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,25 +1,34 @@ -T24gRnJpLCAyMDE2LTA1LTI3IGF0IDE1OjA3ICswMjAwLCBBcm5kIEJlcmdtYW5uIHdyb3RlOg0K -PiBnY2MgaXMgYXBwYXJlbnRseSB1bmFibGVsIHRvIHRyYWNrIHRoZSBzdGF0ZSBvZiB0aGUgbG9j -YWwgJ3Jlc3BfdjInDQo+IHZhcmlhYmxlIGFjcm9zcyB0aGUga3phbGxvYygpIGZ1bmN0aW9uLCBh -bmQgd2FybnMgYWJvdXQgdGhlIHJlc3BvbnNlDQo+IHZhcmlhYmxlIGJlaW5nIHVzZWQgd2l0aG91 -dCBhbiBpbml0aWFsaXphdGlvbjoNCj4gDQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL2ludGVsL2l3 -bHdpZmkvbXZtL252bS5jOiBJbiBmdW5jdGlvbg0KPiDigJhpd2xfbXZtX3VwZGF0ZV9tY2PigJk6 -DQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL2ludGVsL2l3bHdpZmkvbXZtL252bS5jOjcyNzozNjog -d2FybmluZzoNCj4g4oCYbWNjX3Jlc3BfdjHigJkgbWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCBp -biB0aGlzIGZ1bmN0aW9uIFstV21heWJlLQ0KPiB1bmluaXRpYWxpemVkXQ0KPiDCoMKgwqByZXNw -X2NwLT5uX2NoYW5uZWxzID0gbWNjX3Jlc3BfdjEtPm5fY2hhbm5lbHM7DQo+IGRyaXZlcnMvbmV0 -L3dpcmVsZXNzL2ludGVsL2l3bHdpZmkvbXZtL252bS5jOjcyMTozOiB3YXJuaW5nOg0KPiDigJht -Y2NfcmVzcOKAmSBtYXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24gWy1X -bWF5YmUtDQo+IHVuaW5pdGlhbGl6ZWRdDQo+IMKgwqDCoG1lbWNweShyZXNwX2NwLCBtY2NfcmVz -cCwgcmVzcF9sZW4pOw0KPiANCj4gVGhlIHdhcm5pbmcgc2hvd2VkIHVwIGluIHg4NiBhbGxtb2Rj -b25maWcgYWZ0ZXIgbXkgcGF0Y2ggdG8NCj4gdW5oaWRlIC1XbWF5YmUtdW5pbml0aWFsaXplZCB3 -YXJuaW5ncyBieSBkZWZhdWx0IHdhcyBtZXJnZWQsDQo+IHRob3VnaCBpdCBhbHdheXMgZXhpc3Rl -ZCBpbiByYW5kY29uZmlnIGJ1aWxkcy4gSSBkaWQgbm90DQo+IGNhdGNoIHRoZSB3YXJuaW5nIGVh -cmxpZXIgYmVjYXVzZSBJIHdhcyB0ZXN0aW5nIG9uIEFSTSwgd2hpY2gNCj4gbmV2ZXIgcHJvZHVj -ZWQgdGhlIHdhcm5pbmcuDQo+IA0KPiBUaGlzIHJlYXJyYW5nZXMgdGhlIGNvZGUgaW4gYSB3YXkg -dGhhdCBpbXByb3ZlcyByZWFkYWJpbGl0eSBmb3INCj4gYm90aCBodW1hbnMgYW5kIHRoZSBjb21w -aWxlciwgYW5kIHRoYXQgYXZvaWRzIHRoZSB3YXJuaW5nLg0KPiANCj4gU2lnbmVkLW9mZi1ieTog -QXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4NCj4gRml4ZXM6IDZmYTUyNDMwZjBiMyAoIml3 -bHdpZmk6IG12bTogY2hhbmdlIG1jYyB1cGRhdGUgQVBJIikNCj4gLS0tDQoNClRoYW5rcywgQXJu -ZCEgSSBxdWV1ZWQgdGhpcyB2aWEgb3VyIGludGVybmFsIHRyZWUuDQoNCi0tDQpDaGVlcnMsDQpM -dWNhLg== +On Fri, 2016-05-27 at 15:07 +0200, Arnd Bergmann wrote: +> gcc is apparently unablel to track the state of the local 'resp_v2' +> variable across the kzalloc() function, and warns about the response +> variable being used without an initialization: +> +> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c: In function +> ‘iwl_mvm_update_mcc’: +> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:727:36: warning: +> ‘mcc_resp_v1’ may be used uninitialized in this function [-Wmaybe- +> uninitialized] +> resp_cp->n_channels = mcc_resp_v1->n_channels; +> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:721:3: warning: +> ‘mcc_resp’ may be used uninitialized in this function [-Wmaybe- +> uninitialized] +> memcpy(resp_cp, mcc_resp, resp_len); +> +> The warning showed up in x86 allmodconfig after my patch to +> unhide -Wmaybe-uninitialized warnings by default was merged, +> though it always existed in randconfig builds. I did not +> catch the warning earlier because I was testing on ARM, which +> never produced the warning. +> +> This rearranges the code in a way that improves readability for +> both humans and the compiler, and that avoids the warning. +> +> Signed-off-by: Arnd Bergmann <arnd@arndb.de> +> Fixes: 6fa52430f0b3 ("iwlwifi: mvm: change mcc update API") +> --- + +Thanks, Arnd! I queued this via our internal tree. + +-- +Cheers, +Luca. diff --git a/a/content_digest b/N1/content_digest index 7d4cec9..7a7bf94 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -19,30 +19,39 @@ " linux-wireless@vger.kernel.org <linux-wireless@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gRnJpLCAyMDE2LTA1LTI3IGF0IDE1OjA3ICswMjAwLCBBcm5kIEJlcmdtYW5uIHdyb3RlOg0K\n" - "PiBnY2MgaXMgYXBwYXJlbnRseSB1bmFibGVsIHRvIHRyYWNrIHRoZSBzdGF0ZSBvZiB0aGUgbG9j\n" - "YWwgJ3Jlc3BfdjInDQo+IHZhcmlhYmxlIGFjcm9zcyB0aGUga3phbGxvYygpIGZ1bmN0aW9uLCBh\n" - "bmQgd2FybnMgYWJvdXQgdGhlIHJlc3BvbnNlDQo+IHZhcmlhYmxlIGJlaW5nIHVzZWQgd2l0aG91\n" - "dCBhbiBpbml0aWFsaXphdGlvbjoNCj4gDQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL2ludGVsL2l3\n" - "bHdpZmkvbXZtL252bS5jOiBJbiBmdW5jdGlvbg0KPiDigJhpd2xfbXZtX3VwZGF0ZV9tY2PigJk6\n" - "DQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL2ludGVsL2l3bHdpZmkvbXZtL252bS5jOjcyNzozNjog\n" - "d2FybmluZzoNCj4g4oCYbWNjX3Jlc3BfdjHigJkgbWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCBp\n" - "biB0aGlzIGZ1bmN0aW9uIFstV21heWJlLQ0KPiB1bmluaXRpYWxpemVkXQ0KPiDCoMKgwqByZXNw\n" - "X2NwLT5uX2NoYW5uZWxzID0gbWNjX3Jlc3BfdjEtPm5fY2hhbm5lbHM7DQo+IGRyaXZlcnMvbmV0\n" - "L3dpcmVsZXNzL2ludGVsL2l3bHdpZmkvbXZtL252bS5jOjcyMTozOiB3YXJuaW5nOg0KPiDigJht\n" - "Y2NfcmVzcOKAmSBtYXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24gWy1X\n" - "bWF5YmUtDQo+IHVuaW5pdGlhbGl6ZWRdDQo+IMKgwqDCoG1lbWNweShyZXNwX2NwLCBtY2NfcmVz\n" - "cCwgcmVzcF9sZW4pOw0KPiANCj4gVGhlIHdhcm5pbmcgc2hvd2VkIHVwIGluIHg4NiBhbGxtb2Rj\n" - "b25maWcgYWZ0ZXIgbXkgcGF0Y2ggdG8NCj4gdW5oaWRlIC1XbWF5YmUtdW5pbml0aWFsaXplZCB3\n" - "YXJuaW5ncyBieSBkZWZhdWx0IHdhcyBtZXJnZWQsDQo+IHRob3VnaCBpdCBhbHdheXMgZXhpc3Rl\n" - "ZCBpbiByYW5kY29uZmlnIGJ1aWxkcy4gSSBkaWQgbm90DQo+IGNhdGNoIHRoZSB3YXJuaW5nIGVh\n" - "cmxpZXIgYmVjYXVzZSBJIHdhcyB0ZXN0aW5nIG9uIEFSTSwgd2hpY2gNCj4gbmV2ZXIgcHJvZHVj\n" - "ZWQgdGhlIHdhcm5pbmcuDQo+IA0KPiBUaGlzIHJlYXJyYW5nZXMgdGhlIGNvZGUgaW4gYSB3YXkg\n" - "dGhhdCBpbXByb3ZlcyByZWFkYWJpbGl0eSBmb3INCj4gYm90aCBodW1hbnMgYW5kIHRoZSBjb21w\n" - "aWxlciwgYW5kIHRoYXQgYXZvaWRzIHRoZSB3YXJuaW5nLg0KPiANCj4gU2lnbmVkLW9mZi1ieTog\n" - "QXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4NCj4gRml4ZXM6IDZmYTUyNDMwZjBiMyAoIml3\n" - "bHdpZmk6IG12bTogY2hhbmdlIG1jYyB1cGRhdGUgQVBJIikNCj4gLS0tDQoNClRoYW5rcywgQXJu\n" - "ZCEgSSBxdWV1ZWQgdGhpcyB2aWEgb3VyIGludGVybmFsIHRyZWUuDQoNCi0tDQpDaGVlcnMsDQpM\n" - dWNhLg== + "On Fri, 2016-05-27 at 15:07 +0200, Arnd Bergmann wrote:\n" + "> gcc is apparently unablel to track the state of the local 'resp_v2'\n" + "> variable across the kzalloc() function, and warns about the response\n" + "> variable being used without an initialization:\n" + "> \n" + "> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c: In function\n" + "> \342\200\230iwl_mvm_update_mcc\342\200\231:\n" + "> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:727:36: warning:\n" + "> \342\200\230mcc_resp_v1\342\200\231 may be used uninitialized in this function [-Wmaybe-\n" + "> uninitialized]\n" + "> \302\240\302\240\302\240resp_cp->n_channels = mcc_resp_v1->n_channels;\n" + "> drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:721:3: warning:\n" + "> \342\200\230mcc_resp\342\200\231 may be used uninitialized in this function [-Wmaybe-\n" + "> uninitialized]\n" + "> \302\240\302\240\302\240memcpy(resp_cp, mcc_resp, resp_len);\n" + "> \n" + "> The warning showed up in x86 allmodconfig after my patch to\n" + "> unhide -Wmaybe-uninitialized warnings by default was merged,\n" + "> though it always existed in randconfig builds. I did not\n" + "> catch the warning earlier because I was testing on ARM, which\n" + "> never produced the warning.\n" + "> \n" + "> This rearranges the code in a way that improves readability for\n" + "> both humans and the compiler, and that avoids the warning.\n" + "> \n" + "> Signed-off-by: Arnd Bergmann <arnd@arndb.de>\n" + "> Fixes: 6fa52430f0b3 (\"iwlwifi: mvm: change mcc update API\")\n" + "> ---\n" + "\n" + "Thanks, Arnd! I queued this via our internal tree.\n" + "\n" + "--\n" + "Cheers,\n" + Luca. -94ed47f5a704e071a80beb0cc1eb789e9be2311668c8e466ee562366499d0863 +e4b1c42bef4cecce965f41690cfe1a8d5eecbcc5ea7019c203ba8e162b48d562
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.