From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga02.intel.com ([134.134.136.20]:28103 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176AbcE3UhK (ORCPT ); Mon, 30 May 2016 16:37:10 -0400 From: "Coelho, Luciano" To: "Gottlieb, Matti" , "arnd@arndb.de" , "Grumbach, Emmanuel" CC: "linux-kernel@vger.kernel.org" , linuxwifi , "torvalds@linux-foundation.org" , "Harel, Moshe" , "Berg, Johannes" , "kvalo@codeaurora.org" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH] iwlwifi: mvm: avoid harmless -Wmaybe-uninialized warning Date: Mon, 30 May 2016 20:37:02 +0000 Message-ID: <1464640622.19317.54.camel@intel.com> (sfid-20160530_223735_787245_953C512A) References: <1464354462-1940949-1-git-send-email-arnd@arndb.de> In-Reply-To: <1464354462-1940949-1-git-send-email-arnd@arndb.de> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: T24gRnJpLCAyMDE2LTA1LTI3IGF0IDE1OjA3ICswMjAwLCBBcm5kIEJlcmdtYW5uIHdyb3RlOg0K PiBnY2MgaXMgYXBwYXJlbnRseSB1bmFibGVsIHRvIHRyYWNrIHRoZSBzdGF0ZSBvZiB0aGUgbG9j YWwgJ3Jlc3BfdjInDQo+IHZhcmlhYmxlIGFjcm9zcyB0aGUga3phbGxvYygpIGZ1bmN0aW9uLCBh bmQgd2FybnMgYWJvdXQgdGhlIHJlc3BvbnNlDQo+IHZhcmlhYmxlIGJlaW5nIHVzZWQgd2l0aG91 dCBhbiBpbml0aWFsaXphdGlvbjoNCj4gDQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL2ludGVsL2l3 bHdpZmkvbXZtL252bS5jOiBJbiBmdW5jdGlvbg0KPiDigJhpd2xfbXZtX3VwZGF0ZV9tY2PigJk6 DQo+IGRyaXZlcnMvbmV0L3dpcmVsZXNzL2ludGVsL2l3bHdpZmkvbXZtL252bS5jOjcyNzozNjog d2FybmluZzoNCj4g4oCYbWNjX3Jlc3BfdjHigJkgbWF5IGJlIHVzZWQgdW5pbml0aWFsaXplZCBp biB0aGlzIGZ1bmN0aW9uIFstV21heWJlLQ0KPiB1bmluaXRpYWxpemVkXQ0KPiDCoMKgwqByZXNw X2NwLT5uX2NoYW5uZWxzID0gbWNjX3Jlc3BfdjEtPm5fY2hhbm5lbHM7DQo+IGRyaXZlcnMvbmV0 L3dpcmVsZXNzL2ludGVsL2l3bHdpZmkvbXZtL252bS5jOjcyMTozOiB3YXJuaW5nOg0KPiDigJht Y2NfcmVzcOKAmSBtYXkgYmUgdXNlZCB1bmluaXRpYWxpemVkIGluIHRoaXMgZnVuY3Rpb24gWy1X bWF5YmUtDQo+IHVuaW5pdGlhbGl6ZWRdDQo+IMKgwqDCoG1lbWNweShyZXNwX2NwLCBtY2NfcmVz cCwgcmVzcF9sZW4pOw0KPiANCj4gVGhlIHdhcm5pbmcgc2hvd2VkIHVwIGluIHg4NiBhbGxtb2Rj b25maWcgYWZ0ZXIgbXkgcGF0Y2ggdG8NCj4gdW5oaWRlIC1XbWF5YmUtdW5pbml0aWFsaXplZCB3 YXJuaW5ncyBieSBkZWZhdWx0IHdhcyBtZXJnZWQsDQo+IHRob3VnaCBpdCBhbHdheXMgZXhpc3Rl ZCBpbiByYW5kY29uZmlnIGJ1aWxkcy4gSSBkaWQgbm90DQo+IGNhdGNoIHRoZSB3YXJuaW5nIGVh cmxpZXIgYmVjYXVzZSBJIHdhcyB0ZXN0aW5nIG9uIEFSTSwgd2hpY2gNCj4gbmV2ZXIgcHJvZHVj ZWQgdGhlIHdhcm5pbmcuDQo+IA0KPiBUaGlzIHJlYXJyYW5nZXMgdGhlIGNvZGUgaW4gYSB3YXkg dGhhdCBpbXByb3ZlcyByZWFkYWJpbGl0eSBmb3INCj4gYm90aCBodW1hbnMgYW5kIHRoZSBjb21w aWxlciwgYW5kIHRoYXQgYXZvaWRzIHRoZSB3YXJuaW5nLg0KPiANCj4gU2lnbmVkLW9mZi1ieTog QXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4NCj4gRml4ZXM6IDZmYTUyNDMwZjBiMyAoIml3 bHdpZmk6IG12bTogY2hhbmdlIG1jYyB1cGRhdGUgQVBJIikNCj4gLS0tDQoNClRoYW5rcywgQXJu ZCEgSSBxdWV1ZWQgdGhpcyB2aWEgb3VyIGludGVybmFsIHRyZWUuDQoNCi0tDQpDaGVlcnMsDQpM dWNhLg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755203AbcE3UhO (ORCPT ); Mon, 30 May 2016 16:37:14 -0400 Received: from mga02.intel.com ([134.134.136.20]:28103 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752176AbcE3UhK (ORCPT ); Mon, 30 May 2016 16:37:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,391,1459839600"; d="scan'208";a="113034060" From: "Coelho, Luciano" To: "Gottlieb, Matti" , "arnd@arndb.de" , "Grumbach, Emmanuel" CC: "linux-kernel@vger.kernel.org" , linuxwifi , "torvalds@linux-foundation.org" , "Harel, Moshe" , "Berg, Johannes" , "kvalo@codeaurora.org" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" Subject: Re: [PATCH] iwlwifi: mvm: avoid harmless -Wmaybe-uninialized warning Thread-Topic: [PATCH] iwlwifi: mvm: avoid harmless -Wmaybe-uninialized warning Thread-Index: AQHRuBjWq6N6ElrZCkSGyZzBZdqKs5/R5RUA Date: Mon, 30 May 2016 20:37:02 +0000 Message-ID: <1464640622.19317.54.camel@intel.com> References: <1464354462-1940949-1-git-send-email-arnd@arndb.de> In-Reply-To: <1464354462-1940949-1-git-send-email-arnd@arndb.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.252.31.148] Content-Type: text/plain; charset="utf-8" Content-ID: <13CC8AB7B6DAAE4297FE3E682CC24901@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u4UKbINm028647 On Fri, 2016-05-27 at 15:07 +0200, Arnd Bergmann wrote: > gcc is apparently unablel to track the state of the local 'resp_v2' > variable across the kzalloc() function, and warns about the response > variable being used without an initialization: > > drivers/net/wireless/intel/iwlwifi/mvm/nvm.c: In function > ‘iwl_mvm_update_mcc’: > drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:727:36: warning: > ‘mcc_resp_v1’ may be used uninitialized in this function [-Wmaybe- > uninitialized] >    resp_cp->n_channels = mcc_resp_v1->n_channels; > drivers/net/wireless/intel/iwlwifi/mvm/nvm.c:721:3: warning: > ‘mcc_resp’ may be used uninitialized in this function [-Wmaybe- > uninitialized] >    memcpy(resp_cp, mcc_resp, resp_len); > > The warning showed up in x86 allmodconfig after my patch to > unhide -Wmaybe-uninitialized warnings by default was merged, > though it always existed in randconfig builds. I did not > catch the warning earlier because I was testing on ARM, which > never produced the warning. > > This rearranges the code in a way that improves readability for > both humans and the compiler, and that avoids the warning. > > Signed-off-by: Arnd Bergmann > Fixes: 6fa52430f0b3 ("iwlwifi: mvm: change mcc update API") > --- Thanks, Arnd! I queued this via our internal tree. -- Cheers, Luca.