From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support Date: Tue, 31 May 2016 09:34:45 +0200 Message-ID: <1464680085.5978.40.camel@redhat.com> References: <1443787104-24243-1-git-send-email-kraxel@redhat.com> <1443787104-24243-8-git-send-email-kraxel@redhat.com> <1464335163.10663.7.camel@redhat.com> <20160527075027.GW27098@phenom.ffwll.local> <20160530084233.GA27098@phenom.ffwll.local> <1464610010.5179.34.camel@redhat.com> <20160530144325.GJ27098@phenom.ffwll.local> <1464675500.5978.15.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 21BBC6E2DD for ; Tue, 31 May 2016 07:34:47 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: open list , dri-devel , "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org ICBIaSwKCj4gPiBSaWdodCBub3cgdGhlIHZpcnR1YWwgb3V0cHV0cyBhcmUgbGlua2VkIHRvIGRy bV9jcnRjLiAgVG8gYXBwbHkgYW55Cj4gPiBjaGFuZ2VzIEkgbmVlZCB0byBsb29rdXAgdGhlIGNy dGMgdG8gZmlndXJlIHdoaWNoIHZpcnR1YWwgb3V0cHV0IHNob3VsZAo+ID4gYmUgdXBkYXRlZC4K Cj4gPiBTbywgc2V0dGluZyBhY3RpdmVfb25seSBzaG91bGQgbWFrZSBzdXJlIEkgaGF2ZSBhIHZh bGlkIGNydGMgcG9pbnRlciBvbgo+ID4gcGxhbmUgdXBkYXRlcywgcmlnaHQ/ICBJdCBwcm9iYWJs eSBhbHNvIHNraXBzIHRoZSBkaXNhYmxlICsgZW5hYmxlIGNydGMKPiA+IHN0ZXBzIG9uIGNvbW1p dD8gIFdoYXQgaGFwcGVucyB3aGVuIG91dHB1dHMgYXJlIGRpc2FibGVkPwoKPiBOYWgsIEkganVz dCBtaXN1bmRlcnN0b29kIHlvdXIgcGF0Y2guIElmIGl0J3MgYWxsIGFib3V0IGZpbmRpbmcgdGhl Cj4gY29ycmVzcG9uZGluZyBjcnRjLCB0aGVuIHlvdSdyZSBhbGwgZ29vZC4KClllcywgaXQncyBh bGwgYWJvdXQgZmluZGluZyB0aGUgY3J0Yy4KCj4gSSB0aG91Z2h0IHRoZXJlIHdhcyBzb21lCj4g b3RoZXIgcmVhc29uIChsaWtlIHRoZSB2aXJ0dWFsIGh3IGdldHRpbmcgdXBzZXQgYWJvdXQgY2Vy dGFpbiB0aGluZ3MpLgoKdmlydGlvIHdvdWxkbid0IGJlIHVwc2V0LgoKSXQncyBhIHBvaW50bGVz cyBleGVyY2lzZSB0aG91Z2ggdG8gZmlyc3QgZGlzYWJsZSB0aGUgb3V0cHV0LCBqdXN0IHRvCnJl LWVuYWJsZSBpdCB0aGUgbmV4dCBtb21lbnQgd2l0aCB0aGUgbmV3IHBhZ2UtZmxpcHBlZCBmcmFt ZWJ1ZmZlci4gIFNvCkkgZ3Vlc3MgSSBzaG91bGQgbG9vayBhdCB0aGUgYWN0aXZlX29ubHkgdGhp bmcgbmV2ZXJ0aGVsZXNzLgoKPiBidHcgY2FuIHlvdSBwbHMgZHJvcCBhbiBhY2sgb3Igci1iCj4g b250byBteSB2aXJ0aW8gY29udmVyc2lvbj8gSSBhbHJlYWR5IGFkZGVkIHlvdXIgdGVzdGVkLWJ5 LgoKR3JyLCBtYWlsIGlzIG5vdCBpbiBteSBkcmktZGV2ZWwgZm9sZGVyLiAgR3Vlc3MgdGhhdCBp cyB0aGUgPGNlbnNvcmVkPgoiYXZvaWQtZHVwbGljYXRlcyIgbWFpbG1hbiBvcHRpb24gYXQgd29y ay4KCkZlZWwgZnJlZSB0byBqdXN0IGFkZCB0aGUgci1iIHRvby4gIE9yIEknbGwgc2VuZCBpdCBm b3IgdGhlIG5leHQgdmVyc2lvbgpvZiB0aGUgc2VyaWVzLgoKY2hlZXJzLAogIEdlcmQKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755543AbcEaHes (ORCPT ); Tue, 31 May 2016 03:34:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60290 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755290AbcEaHer convert rfc822-to-8bit (ORCPT ); Tue, 31 May 2016 03:34:47 -0400 Message-ID: <1464680085.5978.40.camel@redhat.com> Subject: Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support From: Gerd Hoffmann To: Daniel Vetter Cc: dri-devel , open list , "open list:VIRTIO GPU DRIVER" Date: Tue, 31 May 2016 09:34:45 +0200 In-Reply-To: References: <1443787104-24243-1-git-send-email-kraxel@redhat.com> <1443787104-24243-8-git-send-email-kraxel@redhat.com> <1464335163.10663.7.camel@redhat.com> <20160527075027.GW27098@phenom.ffwll.local> <20160530084233.GA27098@phenom.ffwll.local> <1464610010.5179.34.camel@redhat.com> <20160530144325.GJ27098@phenom.ffwll.local> <1464675500.5978.15.camel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 31 May 2016 07:34:46 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > > Right now the virtual outputs are linked to drm_crtc. To apply any > > changes I need to lookup the crtc to figure which virtual output should > > be updated. > > So, setting active_only should make sure I have a valid crtc pointer on > > plane updates, right? It probably also skips the disable + enable crtc > > steps on commit? What happens when outputs are disabled? > Nah, I just misunderstood your patch. If it's all about finding the > corresponding crtc, then you're all good. Yes, it's all about finding the crtc. > I thought there was some > other reason (like the virtual hw getting upset about certain things). virtio wouldn't be upset. It's a pointless exercise though to first disable the output, just to re-enable it the next moment with the new page-flipped framebuffer. So I guess I should look at the active_only thing nevertheless. > btw can you pls drop an ack or r-b > onto my virtio conversion? I already added your tested-by. Grr, mail is not in my dri-devel folder. Guess that is the "avoid-duplicates" mailman option at work. Feel free to just add the r-b too. Or I'll send it for the next version of the series. cheers, Gerd