From: Johannes Berg <johannes@sipsolutions.net>
To: Yongqin Liu <yongqin.liu@linaro.org>, linux-wireless@vger.kernel.org
Cc: filbranden@google.com
Subject: Re: [PATCH 1/1] version.sh: update to get version with git correctly
Date: Tue, 31 May 2016 11:50:23 +0200 [thread overview]
Message-ID: <1464688223.3076.5.camel@sipsolutions.net> (raw)
In-Reply-To: <1462254528-15911-1-git-send-email-yongqin.liu@linaro.org> (sfid-20160503_075053_321143_A72BBFC5)
On Tue, 2016-05-03 at 13:48 +0800, Yongqin Liu wrote:
> update to get the version information from the
> git repository where this file is located instead of the
> the current directory where it is executed, otherwise if
> there is .git directory in the current directory, it will
> get the wrong version information.
>
> And improved the version check since the tag information
> may not be mirrored like what AOSP does now.
Applied.
> Change-Id: I321113b74bf2a955c202f47dca68c1183ca55318
>
I don't really need a change-id though :)
johannes
prev parent reply other threads:[~2016-05-31 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 5:48 [PATCH 1/1] version.sh: update to get version with git correctly Yongqin Liu
2016-05-31 9:50 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464688223.3076.5.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=filbranden@google.com \
--cc=linux-wireless@vger.kernel.org \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.