From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:40623 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbcEaK3q (ORCPT ); Tue, 31 May 2016 06:29:46 -0400 Message-ID: <1464690582.3076.21.camel@sipsolutions.net> (sfid-20160531_124200_401172_D4657476) Subject: Re: [PATCH 1/3] nl80211: Fix checkpatch warnings From: Johannes Berg To: Julian Calaby Cc: linux-wireless , Kirtika Ruchandani , ruchandani.tina@gmail.com, netdev Date: Tue, 31 May 2016 12:29:42 +0200 In-Reply-To: (sfid-20160530_023028_641313_76E294B4) References: <487a841acb1098e96104f2671399274e82aafeba.1464492195.git.kirtika.ruchandani@gmail.com> (sfid-20160530_023028_641313_76E294B4) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2016-05-30 at 10:30 +1000, Julian Calaby wrote: > Hi All, > > On Sun, May 29, 2016 at 1:30 PM, Kirtika Ruchandani > wrote: > > > > This patch fixes the following checkpatch.pl warnings about > > comments in nl80211.c : > > - networking block comments don't use an empty '/*' line > > - block comments use a trailing '*/' on a separate line > > > > Signed-off-by: Kirtika Ruchandani > The change and logic behind it are sound, so it gets my: > > Reviewed-by: Julian Calaby > > however I'm concerned that this file is a deliberate exception to the > networking comment rules. > It's kinda mixed, I never really enforced one style or the other ... I'm kinda taking both now, with a slight preference towards the networking style perhaps (to please davem :) ) That said, in general I'm not really sure of the value of all of these patches - perhaps the kcalloc() one makes sense, not for checkpatch reasons but rather for size limit/integer overflow reasons, and the ether address assign for general readability, but overall ... I'll have to make up my mind :) johannes