From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer Date: Tue, 31 May 2016 15:09:13 +0200 Message-ID: <1464700153.5978.107.camel@redhat.com> References: <1464691994-5704-1-git-send-email-kraxel@redhat.com> <1464691994-5704-5-git-send-email-kraxel@redhat.com> <20160531123622.GT4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F6116E26D for ; Tue, 31 May 2016 13:09:16 +0000 (UTC) In-Reply-To: <20160531123622.GT4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: open list , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRGksIDIwMTYtMDUtMzEgYXQgMTU6MzYgKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToK Cj4gV2h5IHN0b3JlIGl0IGluIHRoZSBmYiBhbmQgbm90IGVnLiB0aGUgcGxhbmUgc3RhdGU/CgpX ZWxsLCBkcm1fcGxhbmVfc3RhdGUgaXMgYWxsb2NhdGVkIGJ5IGRybV9hdG9taWNfaGVscGVyX3Vw ZGF0ZV9wbGFuZS4KCldoZW4gc3RpY2tpbmcgdGhlIGhvdHNwb3QgaW50byB0aGUgdGhlIHBsYW5l IHN0YXRlIHdlIGhhdmUgdG8gYWRkIGhvdF94CmFuZCBob3RfeSBwYXJhbWV0ZXJzIHRvIGRybV9w bGFuZV9mdW5jcy0+dXBkYXRlX3BsYW5lKCkgYW5kIGNhdXNlIHF1aXRlCnNvbWUgY2h1cm4gYWxs IG92ZXIgdGhlIGRybSB0cmVlLgoKT3IgY3JlYXRlIGEgc2VwYXJhdGUgY29kZSBwYXRoIGZvciBj dXJzb3IgdXBkYXRlcyB3aGljaCB1c2VzIGEgc3BlY2lhbApkcm1fYXRvbWljX2hlbHBlcl91cGRh dGVfcGxhbmUgdmVyc2lvbiwgd2hpY2ggZG9lc24ndCBsb29rIHZlcnkKYXR0cmFjdGl2ZSB0b28g ZHVlIHRvIGNvZGUgZHVwbGljYXRpb24uCgpTdGlja2luZyBpdCBpbnRvIHRoZSBkcm1fZnJhbWVi dWZmZXIgaW5zdGVhZCBsb29rcyBsaWtlIGEgcmVhc29uYWJsZQphbHRlcm5hdGl2ZS4KCkknbSBv cGVuIHRvIGJldHRlciBzdWdnZXN0aW9ucy4KCmNoZWVycywKICBHZXJkCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754581AbcEaNJS (ORCPT ); Tue, 31 May 2016 09:09:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36344 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754532AbcEaNJQ convert rfc822-to-8bit (ORCPT ); Tue, 31 May 2016 09:09:16 -0400 Message-ID: <1464700153.5978.107.camel@redhat.com> Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer From: Gerd Hoffmann To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: dri-devel@lists.freedesktop.org, open list Date: Tue, 31 May 2016 15:09:13 +0200 In-Reply-To: <20160531123622.GT4329@intel.com> References: <1464691994-5704-1-git-send-email-kraxel@redhat.com> <1464691994-5704-5-git-send-email-kraxel@redhat.com> <20160531123622.GT4329@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 31 May 2016 13:09:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote: > Why store it in the fb and not eg. the plane state? Well, drm_plane_state is allocated by drm_atomic_helper_update_plane. When sticking the hotspot into the the plane state we have to add hot_x and hot_y parameters to drm_plane_funcs->update_plane() and cause quite some churn all over the drm tree. Or create a separate code path for cursor updates which uses a special drm_atomic_helper_update_plane version, which doesn't look very attractive too due to code duplication. Sticking it into the drm_framebuffer instead looks like a reasonable alternative. I'm open to better suggestions. cheers, Gerd