Re: [PATCH iw] add "channels" PHY command listing frequencies with more details

[Johannes Berg <johannes@sipsolutions.net>]

On Tue, 2016-05-31 at 15:10 +0200, Rafał Miłecki wrote:

> > Unfortunately, I get compiler warnings about width_* being possibly
> > used uninitialized. Can you address that please?
> It's nice your compiled got this mistake, my didn't. There were
> actually meant to be static. I'll fix that.

I actually think the compiler is wrong, and there's no reason for them
to be static, is there?

The first iteration of the loop should always initialize since -1 is
used for initialization?

In any case, I'd prefer to avoid static, if necessary pass some kind of
context structure in to the function?

> > > +TOPLEVEL(channels, NULL, NL80211_CMD_GET_WIPHY, 0, CIB_PHY,
> > > handle_channels, "Show available channels.");
> > Maybe that should be allowed for a CIB_DEV too?
> Since this is PHY specific, I was thinking it should be CIB_PHY. I
> didn't see reason to allow querying devices. Similarly we don't
> support "iw dev wlan0 reg get".
> 
> Anyway, I can change that if you think it's better for some reason.

I was just thinking that supporting it with wlan0 would in certain
cases make it easier for the user (not having to look up the phy
number)

> Any hint how to make command usable with both: phy and dev?

Just add:

TOPLEVEL(channels, NULL, NL80211_CMD_GET_WIPHY, 0, CIB_NETDEV, ...);

johannes