From: Johannes Berg <johannes@sipsolutions.net>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] cfg80211: Allow cfg80211_connect_result() errors to be distinguished
Date: Tue, 31 May 2016 15:19:55 +0200 [thread overview]
Message-ID: <1464700795.3076.29.camel@sipsolutions.net> (raw)
In-Reply-To: <1464643010-29225-1-git-send-email-jouni@qca.qualcomm.com>
On Tue, 2016-05-31 at 00:16 +0300, Jouni Malinen wrote:
> Previously, the status parameter to cfg80211_connect_result() was
> documented as using WLAN_STATUS_UNSPECIFIED_FAILURE (1) when the real
> status code for the failure is not known. This value can be used by
> an
> AP (and often is) and as such, user space cannot distinguish between
> explicitly rejected authentication/association and not being able to
> even try to associate or not receiving a response from the AP.
>
> Add a new inline function, cfg80211_connect_timeout(), to be used
> when
> the driver knows that the connection attempt failed due to a reason
> where connection could not be attempt or no response was received
> from
> the AP. The internal functions now allow a negative status value (-1)
> to
> be used as an indication of this special case. This results in the
> NL80211_ATTR_TIMED_OUT to be added to the NL80211_CMD_CONNECT event
> to
> allow user space to determine this case was hit. For backwards
> compatibility, NL80211_STATUS_CODE with the value
> WLAN_STATUS_UNSPECIFIED_FAILURE is still indicated in the event in
> such
> a case.
>
Applied, with a fix to the cfg80211_connect_bss() prototype.
I also added cfg80211_connect_timeout to the docbook.
johannes
prev parent reply other threads:[~2016-05-31 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 21:16 [PATCH] cfg80211: Allow cfg80211_connect_result() errors to be distinguished Jouni Malinen
2016-05-31 13:19 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464700795.3076.29.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.