From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754868AbcEaRHk (ORCPT ); Tue, 31 May 2016 13:07:40 -0400 Received: from smtprelay0164.hostedemail.com ([216.40.44.164]:50787 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750880AbcEaRHj (ORCPT ); Tue, 31 May 2016 13:07:39 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:69:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:3874:4321:5007:6691:7903:10004:10400:10848:11232:11658:11783:11914:12043:12048:12517:12519:12683:12740:13069:13161:13229:13311:13357:13439:13894:14181:14659:14721:21080:21433:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: shoe02_422086b747d31 X-Filterd-Recvd-Size: 2189 Message-ID: <1464714453.14627.32.camel@perches.com> Subject: Re: [PATCH v2 1/4] staging : comedi : fix type issues in s626.c From: Joe Perches To: Ian Abbott , Ravishankar Karkala Mallikarjunayya , hsweeten@visionengravers.com, gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Tue, 31 May 2016 10:07:33 -0700 In-Reply-To: <574D6786.6040500@mev.co.uk> References: <1464413211-7947-1-git-send-email-ravishankarkm32@gmail.com> <574D6786.6040500@mev.co.uk> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2016-05-31 at 11:29 +0100, Ian Abbott wrote: > On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote: > > > > This is a patch to the s626.c file that fixes up a type issues like > > i.e Prefer kernel type 'u8' over 'uint8_t' > >      Prefer kernel type 'u16' over 'uint16_t' > >      Prefer kernel type 'u32' over 'uint32_t' > >      Prefer kernel type 's16' over 'int16_t' > >      Prefer kernel type 's32' over 'int32_t' > > found by the checkpatch.pl tool. > > > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > > --- > > changes since v1: Rework > > --- > >   drivers/staging/comedi/drivers/s626.c | 212 +++++++++++++++++----------------- > >   1 file changed, 106 insertions(+), 106 deletions(-) > > > Thanks.  It would have been nice if the checkpatch.pl tool detected  > _all_ the instances of these types.  As a result of this patch, s626.c  > contains a mixture of the different integer type styles.  I guess we can  > fix that up later though. Seems trivial enough to do. There was a possible issue with converting int_t types that were used as uapi function arguments. checkpatch currently warns only about variable declarations and not function declarations.  It doesn't convert casts either. Should it?