From: David Turner <dturner@twopensource.com>
To: Michael Haggerty <mhagger@alum.mit.edu>,
Junio C Hamano <gitster@pobox.com>
Cc: "Jeff King" <peff@peff.net>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 12/13] dir_iterator: new API for iterating over a directory tree
Date: Tue, 31 May 2016 20:12:34 -0400 [thread overview]
Message-ID: <1464739954.3988.6.camel@twopensource.com> (raw)
In-Reply-To: <e99655e5d919852479d223caec42e5bb294b4a2c.1464537050.git.mhagger@alum.mit.edu>
On Mon, 2016-05-30 at 09:55 +0200, Michael Haggerty wrote:
> +struct dir_iterator_level {
> + int initialized;
> +
> + DIR *dir;
> +
> + /*
> + * The length of the directory part of refname at this level
"refname"? Isn't this was for directories?
> + if (lstat(iter->base.path.buf, &iter
->base.st) < 0)
> + continue; /* silently skip */
Should we warn on non-ENOENT errors here?
> +/*
> + * End the iteration before it has been exhausted. Free the
> reference
s/reference/directory/
next prev parent reply other threads:[~2016-06-01 0:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 7:55 [PATCH 00/13] Reference iterators Michael Haggerty
2016-05-30 7:55 ` [PATCH 01/13] refs: remove unnecessary "extern" keywords Michael Haggerty
2016-05-30 7:55 ` [PATCH 02/13] do_for_each_ref(): move docstring to the header file Michael Haggerty
2016-05-30 7:55 ` [PATCH 03/13] refs: use name "prefix" consistently Michael Haggerty
2016-05-30 7:55 ` [PATCH 04/13] delete_refs(): add a flags argument Michael Haggerty
2016-05-30 7:55 ` [PATCH 05/13] remote rm: handle symbolic refs correctly Michael Haggerty
2016-05-30 7:55 ` [PATCH 06/13] get_ref_cache(): only create an instance if there is a submodule Michael Haggerty
2016-05-30 7:55 ` [PATCH 07/13] entry_resolves_to_object(): rename function from ref_resolves_to_object() Michael Haggerty
2016-05-30 7:55 ` [PATCH 08/13] ref_resolves_to_object(): new function Michael Haggerty
2016-05-30 7:55 ` [PATCH 09/13] refs: introduce an iterator interface Michael Haggerty
2016-05-30 15:22 ` Ramsay Jones
2016-05-30 16:57 ` Ramsay Jones
2016-05-31 1:16 ` Michael Haggerty
2016-05-31 5:29 ` Eric Sunshine
2016-05-31 7:59 ` Michael Haggerty
2016-05-31 23:12 ` Eric Sunshine
2016-06-03 11:48 ` Michael Haggerty
2016-05-31 6:10 ` Junio C Hamano
2016-05-31 8:45 ` Michael Haggerty
2016-06-02 10:08 ` Duy Nguyen
2016-06-02 16:23 ` Michael Haggerty
2016-05-30 7:55 ` [PATCH 10/13] do_for_each_ref(): reimplement using reference iteration Michael Haggerty
2016-05-30 7:55 ` [PATCH 11/13] for_each_reflog(): don't abort for bad references Michael Haggerty
2016-05-30 7:55 ` [PATCH 12/13] dir_iterator: new API for iterating over a directory tree Michael Haggerty
2016-06-01 0:12 ` David Turner [this message]
2016-06-03 11:57 ` Michael Haggerty
2016-05-30 7:55 ` [PATCH 13/13] for_each_reflog(): reimplement using iterators Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464739954.3988.6.camel@twopensource.com \
--to=dturner@twopensource.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.