Re: freevxfs: hp-ux support. patchset 1-7/7 rev 2

["Krzysztof Błaszkowski" <kb@sysmikro.com.pl>]

Hi Christoph,

On Wed, 2016-06-01 at 00:33 -0700, Christoph Hellwig wrote:

> Yeah, this was just getting started.  I've spent some more time on the
> whole inode issues and have implemented this a bit different from what
> you did, although the end result is very similar.  Can you take a look
> at the tree here:
> 
> 	http://git.infradead.org/users/hch/vfs.git/shortlog/refs/heads/freevxfs
> 
> > Do you think other patches should be updated with regard to the patch
> > you sent ?
> 
> Please take a look at the branch above.  

I think that there are no "kfree(pfp); kfree(sfp); return 0;" in
vxfs_read_fshead() still. Are pfp and sfp needed anywhere ? I am sure
they are not so there is a memory leak without these kfrees every mount.

I am not sure absolutely of that read_fshead() is missing these kfrees
because I have seen just these diffs, anyway I did not notice "+kfree".

so .. whose patch is more accurate ?

needles to say that I prefer to have limited scope of visibility of
inode_cachep to the inode.c only.

Thanks,

-- 
Krzysztof Blaszkowski