diff for duplicates of <1464805433.22178.191.camel@linux.intel.com> diff --git a/a/1.txt b/N1/1.txt index 088178c..56a6bf0 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,5 +1,5 @@ On Wed, 2016-06-01 at 16:12 +0900, Minchan Kim wrote: ->A +> > Hi Tim, > > To me, this reorganization is too limited and not good for me, @@ -13,31 +13,25 @@ On Wed, 2016-06-01 at 16:12 +0900, Minchan Kim wrote: This is also my goal to group pages that are either under the same mapping or are anonymous pages together so we can reduce the i_mmap_lock -acquisition. A One logic that's yet to be implemented in your patch +acquisition. One logic that's yet to be implemented in your patch is the grouping of similar pages together so we only need one i_mmap_lock -acquisition. A Doing this efficiently is non-trivial. A +acquisition. Doing this efficiently is non-trivial. I punted the problem somewhat in my patch and elected to defer the processing of the anonymous pages at the end so they are naturally grouped without -having to traverse the page_list more than once. A So I'm batching the +having to traverse the page_list more than once. So I'm batching the anonymous pages but the file mapped pages were not grouped. In your implementation, you may need to traverse the page_list in two pass, where the first one is to categorize the pages and grouping them and the second one -is the actual processing. A Then the lock batching can be implemented -for the pages. A Otherwise the locking is still done page by page in +is the actual processing. Then the lock batching can be implemented +for the pages. Otherwise the locking is still done page by page in your patch, and can only be batched if the next page on page_list happens -to have the same mapping. A Your idea of using a spl_batch_pages is pretty -neat. A It may need some enhancement so it is known whether some locks +to have the same mapping. Your idea of using a spl_batch_pages is pretty +neat. It may need some enhancement so it is known whether some locks are already held for lock batching purpose. Thanks. Tim - --- -To unsubscribe, send a message with 'unsubscribe linux-mm' in -the body to majordomo@kvack.org. For more info on Linux MM, -see: http://www.linux-mm.org/ . -Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index c392082..20819bf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -20,7 +20,7 @@ "\00:1\0" "b\0" "On Wed, 2016-06-01 at 16:12 +0900, Minchan Kim wrote:\n" - ">A \n" + ">\302\240\n" "> Hi Tim,\n" "> \n" "> To me, this reorganization is too limited and not good for me,\n" @@ -34,33 +34,27 @@ "\n" "This is also my goal to group pages that are either under the same\n" "mapping or are anonymous pages together so we can reduce the i_mmap_lock\n" - "acquisition. A One logic that's yet to be implemented in your patch\n" + "acquisition. \302\240One logic that's yet to be implemented in your patch\n" "is the grouping of similar pages together so we only need one i_mmap_lock\n" - "acquisition. A Doing this efficiently is non-trivial. A \n" + "acquisition. \302\240Doing this efficiently is non-trivial. \302\240\n" "\n" "I punted the problem somewhat in my patch and elected to defer the processing\n" "of the anonymous pages at the end so they are naturally grouped without\n" - "having to traverse the page_list more than once. A So I'm batching the\n" + "having to traverse the page_list more than once. \302\240So I'm batching the\n" "anonymous pages but the file mapped pages were not grouped.\n" "\n" "In your implementation, you may need to traverse the page_list in two pass, where the\n" "first one is to categorize the pages and grouping them and the second one\n" - "is the actual processing. A Then the lock batching can be implemented\n" - "for the pages. A Otherwise the locking is still done page by page in\n" + "is the actual processing. \302\240Then the lock batching can be implemented\n" + "for the pages. \302\240Otherwise the locking is still done page by page in\n" "your patch, and can only be batched if the next page on page_list happens\n" - "to have the same mapping. A Your idea of using a spl_batch_pages is pretty\n" - "neat. A It may need some enhancement so it is known whether some locks\n" + "to have the same mapping. \302\240Your idea of using a spl_batch_pages is pretty\n" + "neat. \302\240It may need some enhancement so it is known whether some locks\n" "are already held for lock batching purpose.\n" "\n" "\n" "Thanks.\n" "\n" - "Tim\n" - "\n" - "--\n" - "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" - "the body to majordomo@kvack.org. For more info on Linux MM,\n" - "see: http://www.linux-mm.org/ .\n" - "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" + Tim -94a0b840b197fe72f2b564186c8cab6bdad8700e2a7b56dedaad14c5d9604752 +a33747d4c30f12213f6dd1a7c0ade0b0451ca174f4b744a251a2f622d5a0dc08
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.