All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Andrew Bradford <andrew@bradfordembedded.com>,
	openembedded-core@lists.openembedded.org
Cc: Andrew Bradford <andrew.bradford@kodakalaris.com>
Subject: Re: [PATCH 1/3] oe-buildenv-internal: Add P4CONFIG to BB_ENV_EXTRAWHITE_OE
Date: Thu, 02 Jun 2016 16:53:52 +0100	[thread overview]
Message-ID: <1464882832.13979.4.camel@linuxfoundation.org> (raw)
In-Reply-To: <1464205571-26293-2-git-send-email-andrew@bradfordembedded.com>

On Wed, 2016-05-25 at 15:46 -0400, Andrew Bradford wrote:
> From: Andrew Bradford <andrew.bradford@kodakalaris.com>
> 
> So that the user's P4CONFIG variable can be used by recipes which
> utilize the perforce fetcher.
> 
> References [YOCTO #6303]
> 
> Signed-off-by: Andrew Bradford <andrew.bradford@kodakalaris.com>
> ---
>  scripts/oe-buildenv-internal | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/oe-buildenv-internal b/scripts/oe-buildenv
> -internal
> index 81ee784..e51b950 100755
> --- a/scripts/oe-buildenv-internal
> +++ b/scripts/oe-buildenv-internal
> @@ -114,7 +114,7 @@ BB_ENV_EXTRAWHITE_OE="MACHINE DISTRO TCMODE
> TCLIBC HTTP_PROXY http_proxy \
>  HTTPS_PROXY https_proxy FTP_PROXY ftp_proxy FTPS_PROXY ftps_proxy
> ALL_PROXY \
>  all_proxy NO_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK
> BB_SRCREV_POLICY \
>  SDKMACHINE BB_NUMBER_THREADS BB_NO_NETWORK PARALLEL_MAKE
> GIT_PROXY_COMMAND \
> -SOCKS5_PASSWD SOCKS5_USER SCREENDIR STAMPS_DIR BBPATH_EXTRA"
> +SOCKS5_PASSWD SOCKS5_USER SCREENDIR STAMPS_DIR BBPATH_EXTRA
> P4CONFIG"
>  
>  BB_ENV_EXTRAWHITE="$(echo $BB_ENV_EXTRAWHITE $BB_ENV_EXTRAWHITE_OE |
> tr ' ' '\n' | LC_ALL=C sort --unique | tr '\n' ' ')"

With the recent changes to the bitbake fetcher, its able to pull
environment variables out of BB_ORIGENV. This should mean this patch
isn't necessary?

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=f9c623ddbfc140c0c8911f06aa2824edef8a5f4f

Cheers,

Richard



  reply	other threads:[~2016-06-02 15:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25 19:46 [PATCH 0/3] Setup for bitbake perforce fetcher changes Andrew Bradford
2016-05-25 19:46 ` [PATCH 1/3] oe-buildenv-internal: Add P4CONFIG to BB_ENV_EXTRAWHITE_OE Andrew Bradford
2016-06-02 15:53   ` Richard Purdie [this message]
2016-05-25 19:46 ` [PATCH 2/3] bitbake.conf: Add P4DIR and FETCHCMD_p4 Andrew Bradford
2016-06-02 15:56   ` Richard Purdie
2016-06-02 17:06     ` Andrew Bradford
2016-05-25 19:46 ` [PATCH 3/3] base.bbclass: p4 fetcher supports srcrev Andrew Bradford
2016-06-17 12:52   ` Andrew Bradford
2016-06-17 16:08     ` Richard Purdie
2016-06-02 13:41 ` [PATCH 0/3] Setup for bitbake perforce fetcher changes Andrew Bradford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464882832.13979.4.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=andrew.bradford@kodakalaris.com \
    --cc=andrew@bradfordembedded.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.