All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH] Revert "cpufreq: intel_pstate: Enable PPC enforcement for servers"
Date: Thu, 02 Jun 2016 15:05:21 -0700	[thread overview]
Message-ID: <1464905121.3970.67.camel@linux.intel.com> (raw)
In-Reply-To: <2942391.Y8jFCPZgiC@vostro.rjw.lan>

On Fri, 2016-06-03 at 00:00 +0200, Rafael J. Wysocki wrote:
> On Wednesday, June 01, 2016 05:41:57 PM Srinivas Pandruvada wrote:
> > 
> > This change reverts
> > 'commit 2b3ec7650584 ("cpufreq: intel_pstate: Enable PPC
> > enforcement for
> > servers")'
> > 
> > Intel P State uses max P-State as the max turbo P-State. This max
> > P-State
> > can be limited by ACPI _PSS table entry 0. After
> > 'commit 9522a2ff9cde ("cpufreq: intel_pstate: Enforce _PPC
> > limits")''
> > the _PSS table entry[0] will be used to cap max performance for
> > enterprise and performance server by default.
> > 
> > Even though this is correct processing, but when the performance
> > results
> > are compared with the version before the above commit, then
> > obviously the
> > results will be worse, if the _PSS table entry 0 is not the max
> > turbo
> > P-State.
> > 
> > So to minimize impact on performance, this revert will disable the
> > default
> > enforcement of ACPI _PSS and ACPI _PPC. So this feature can only
> > only be
> > explicitly activated by kernel command line
> > intel_pstate=support_acpi_ppc
> > 
> > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel
> > .com>
> Thanks for the revert, but I'm wondering if we can explore one more
> option.
> 
> Namely, if _PSS doesn't contain the turbo state, but we know the
> turbo range is
> there from the CPU, we can still use it and interpret _PPC for the
> max state as
> a permission to go into the turbo range.
> 
> What do you think?
Looks like a good idea. I will experiment. What is your deadline for
-rc2 fixes?
It will give me more time to experiment and test.

Thanks,
Srinivas

> 
> Thanks,
> Rafael
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-06-02 22:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-02  0:41 [PATCH] Revert "cpufreq: intel_pstate: Enable PPC enforcement for servers" Srinivas Pandruvada
2016-06-02 22:00 ` Rafael J. Wysocki
2016-06-02 22:05   ` Srinivas Pandruvada [this message]
2016-06-02 22:33     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464905121.3970.67.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.