From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752845AbcFCAlZ (ORCPT ); Thu, 2 Jun 2016 20:41:25 -0400 Received: from mail.windriver.com ([147.11.1.11]:53850 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751350AbcFCAkV (ORCPT ); Thu, 2 Jun 2016 20:40:21 -0400 From: Paul Gortmaker To: linux-kernel@vger.kernel.org, Lee Jones , Kyungmin Park , Javier Martinez Canillas Cc: Paul Gortmaker , Laxman Dewangan , Chaitanya Bandi , Mallikarjun Kasoju Subject: [PATCH 4/5] mfd: max77620: make it explicitly non-modular Date: Thu, 2 Jun 2016 20:39:49 -0400 Message-Id: <1464914390-23520-5-git-send-email-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1464914390-23520-1-git-send-email-paul.gortmaker@windriver.com> References: <1464914390-23520-1-git-send-email-paul.gortmaker@windriver.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The Kconfig currently controlling compilation of this code is: drivers/mfd/Kconfig:config MFD_MAX77620 drivers/mfd/Kconfig: bool "Maxim Semiconductor MAX77620 and MAX20024 PMIC Support" ...meaning that it currently is not being built as a module by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_i2c_driver() uses the same init level priority as builtin_i2c_driver() the init ordering remains unchanged with this commit. Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. We also delete the MODULE_LICENSE tag etc. since all that information was (or is now) contained at the top of the file in the comments. Cc: Lee Jones Cc: Laxman Dewangan Cc: Chaitanya Bandi Cc: Mallikarjun Kasoju Signed-off-by: Paul Gortmaker --- drivers/mfd/max77620.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index 199d261990be..84a830598fc9 100644 --- a/drivers/mfd/max77620.c +++ b/drivers/mfd/max77620.c @@ -31,7 +31,7 @@ #include #include #include -#include +#include #include #include #include @@ -566,7 +566,6 @@ static const struct i2c_device_id max77620_id[] = { {"max20024", MAX20024}, {}, }; -MODULE_DEVICE_TABLE(i2c, max77620_id); static const struct dev_pm_ops max77620_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(max77620_i2c_suspend, max77620_i2c_resume) @@ -580,11 +579,4 @@ static struct i2c_driver max77620_driver = { .probe = max77620_probe, .id_table = max77620_id, }; - -module_i2c_driver(max77620_driver); - -MODULE_DESCRIPTION("MAX77620/MAX20024 Multi Function Device Core Driver"); -MODULE_AUTHOR("Laxman Dewangan "); -MODULE_AUTHOR("Chaitanya Bandi "); -MODULE_AUTHOR("Mallikarjun Kasoju "); -MODULE_LICENSE("GPL v2"); +builtin_i2c_driver(max77620_driver); -- 2.4.3