From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:42426 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbcFEU5n (ORCPT ); Sun, 5 Jun 2016 16:57:43 -0400 Subject: Patch "ext4: fix check of dqget() return value in ext4_ioctl_setproject()" has been added to the 4.6-stable tree To: seth.forshee@canonical.com, gregkh@linuxfoundation.org, jack@suse.cz, tytso@mit.edu Cc: , From: Date: Sun, 05 Jun 2016 13:57:42 -0700 Message-ID: <146516026215029@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: This is a note to let you know that I've just added the patch titled ext4: fix check of dqget() return value in ext4_ioctl_setproject() to the 4.6-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: ext4-fix-check-of-dqget-return-value-in-ext4_ioctl_setproject.patch and it can be found in the queue-4.6 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >>From ff0bc08454917964291f72ee5b8eca66de4bc250 Mon Sep 17 00:00:00 2001 From: Seth Forshee Date: Thu, 5 May 2016 10:52:38 -0400 Subject: ext4: fix check of dqget() return value in ext4_ioctl_setproject() From: Seth Forshee commit ff0bc08454917964291f72ee5b8eca66de4bc250 upstream. A failed call to dqget() returns an ERR_PTR() and not null. Fix the check in ext4_ioctl_setproject() to handle this correctly. Fixes: 9b7365fc1c82 ("ext4: add FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR interface support") Signed-off-by: Seth Forshee Signed-off-by: Theodore Ts'o Reviewed-by: Jan Kara Signed-off-by: Greg Kroah-Hartman --- fs/ext4/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -365,7 +365,7 @@ static int ext4_ioctl_setproject(struct struct dquot *transfer_to[MAXQUOTAS] = { }; transfer_to[PRJQUOTA] = dqget(sb, make_kqid_projid(kprojid)); - if (transfer_to[PRJQUOTA]) { + if (!IS_ERR(transfer_to[PRJQUOTA])) { err = __dquot_transfer(inode, transfer_to); dqput(transfer_to[PRJQUOTA]); if (err) Patches currently in stable-queue which might be from seth.forshee@canonical.com are queue-4.6/ext4-fix-check-of-dqget-return-value-in-ext4_ioctl_setproject.patch