From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Balbir Singh <bsingharora@gmail.com>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm: use _raw variant of page table accessors
Date: Mon, 06 Jun 2016 08:30:53 +1000 [thread overview]
Message-ID: <1465165853.4274.22.camel@kernel.crashing.org> (raw)
In-Reply-To: <7ba4cc59-351c-e990-97b4-c3429a0e7f34@gmail.com>
On Fri, 2016-06-03 at 15:34 +1000, Balbir Singh wrote:
>
> Can we just save the cpu_to_be64(_PAGE_PTE) as _BE64_PAGE_PTE constant
> in big-endian (pgtable-be-types.h) and similar for other things. I know its
> not the best option, but we don't really expect these bits to change often or anymore
>
How does that help ? The compiler solves it at compile time either
way, I'm not sure adding yet another constant will improve
readability here.
Cheers,
Ben.
next prev parent reply other threads:[~2016-06-05 22:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 10:59 [PATCH] powerpc/mm: use _raw variant of page table accessors Aneesh Kumar K.V
2016-06-01 22:13 ` Ram Pai
2016-06-02 7:44 ` Michael Ellerman
2016-06-03 5:34 ` Balbir Singh
2016-06-05 22:30 ` Benjamin Herrenschmidt [this message]
2016-06-06 5:33 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465165853.4274.22.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.