All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Mel Gorman <mgorman@suse.de>, lkml <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	kirill@shutemov.name
Subject: Re: [patch] futex: Fix v4.6+ ltp futex_wait04 regression
Date: Mon, 06 Jun 2016 15:34:16 +0200	[thread overview]
Message-ID: <1465220056.4236.5.camel@gmail.com> (raw)
In-Reply-To: <20160606130719.GA30935@twins.programming.kicks-ass.net>

On Mon, 2016-06-06 at 15:07 +0200, Peter Zijlstra wrote:

> > @@ -654,12 +666,14 @@ get_futex_key(u32 __user *uaddr, int fsh
> >  
> >  > > 	> > 	> > key->both.offset |= FUT_OFF_INODE; /* inode-based key */
> >  > > 	> > 	> > key->shared.inode = inode;
> > -> > 	> > 	> > key->shared.pgoff = basepage_index(page);
> > +> > 	> > 	> > key->shared.pgoff = basepage_index(pinned);
> 
> But this seems to be the actual fix;

Yup, the three 'pinned' lines alone work just fine.

	-Mike

  reply	other threads:[~2016-06-06 13:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06  9:40 [patch] futex: Fix v4.6+ ltp futex_wait04 regression Mike Galbraith
2016-06-06 13:07 ` Peter Zijlstra
2016-06-06 13:34   ` Mike Galbraith [this message]
2016-06-06 13:46     ` Mike Galbraith
2016-06-07 10:50 ` Mel Gorman
2016-06-07 11:20   ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465220056.4236.5.camel@gmail.com \
    --to=umgwanakikbuti@gmail.com \
    --cc=bigeasy@linutronix.de \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.