From: Keller, Jacob E <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 09/18] fm10k: wait for queues to drain fully before stop_hw
Date: Mon, 6 Jun 2016 17:38:27 +0000 [thread overview]
Message-ID: <1465234707.28126.0.camel@intel.com> (raw)
In-Reply-To: <20160603224228.10192-10-jacob.e.keller@intel.com>
On Fri, 2016-06-03 at 15:42 -0700, Jacob Keller wrote:
> It turns out that VFs also suffer from the same queue issue as PFs,
> and
> can't simply perform a datapath reset. Add a looping delay for
> queueus
> which will sleep and then check the queues to see if they are drained
> before calling stop_hw. If they take longer than 50 loops (~500ms,
> longest delay I found necessary while testing), issue a dev_err
> message
> and continue with the reset. For PFs, this should trigger a datapath
> reset and a recovery. For VFs this will likely cause the VF to be
> stuck
> and need re-creating. Unfortunately there isn't anything else the
> driver
> can do in response.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
It looks like after some testing, this patch may need changes.
Thanks,
Jake
next prev parent reply other threads:[~2016-06-06 17:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 22:42 [Intel-wired-lan] [PATCH v1 00/18] fm10k reset + suspend/resume changes Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 01/18] fm10k: no need to continue in fm10k_down if __FM10K_DOWN already set Jacob Keller
2016-07-11 19:23 ` Singh, Krishneil K
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 02/18] fm10k: avoid possible null pointer dereference in fm10k_update_stats Jacob Keller
2016-07-11 19:24 ` Singh, Krishneil K
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 03/18] fm10k: prevent multiple threads updating statistics Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 04/18] fm10k: Reset mailbox global interrupts Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 05/18] fm10k: don't stop reset due to FM10K_ERR_REQUESTS_PENDING Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 06/18] fm10k: perform data path reset even when switch is not ready Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 07/18] fm10k: use actual hardware registers when checking for pending Tx Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 08/18] fm10k: only warn when stop_hw fails with FM10K_ERR_REQUESTS_PENDING Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 09/18] fm10k: wait for queues to drain fully before stop_hw Jacob Keller
2016-06-06 17:38 ` Keller, Jacob E [this message]
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 10/18] fm10k: split fm10k_reinit into two functions Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 11/18] fm10k: implement prepare_suspend and handle_resume Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 12/18] fm10k: use common reset flow when handling io errors from PCI stack Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 13/18] fm10k: implement reset_notify handler for PCIe FLR events Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 14/18] fm10k: use common flow for suspend and resume Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 15/18] fm10k: enable bus master after every reset Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 16/18] fm10k: check if PCIe link is restored Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 17/18] fm10k: implement request_lport_map pointer Jacob Keller
2016-06-03 22:42 ` [Intel-wired-lan] [PATCH v1 18/18] fm10k: bump version number Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465234707.28126.0.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.