From: Scott Wood <oss@buserror.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver
Date: Mon, 06 Jun 2016 12:56:48 -0500 [thread overview]
Message-ID: <1465235808.22191.86.camel@buserror.net> (raw)
In-Reply-To: <20160606182223.1636b0df@bbrezillon>
On Mon, 2016-06-06 at 18:22 +0200, Boris Brezillon wrote:
> On Mon, 6 Jun 2016 17:36:10 +0200
> Hans de Goede <hdegoede@redhat.com> wrote:
>
> > > +#ifndef CONFIG_SPL_BUILD
> > > +void sunxi_nand_init(void);
> > > +#endif
> > > +
> >
> > Can we have this in a header somewhere please, and without
> > the #ifdef around it, that is not necessary for prototypes.
>
> Hehe, I was expecting this one :-). Do you know where I should put this
> prototype definition? A board.h file in board/sunxi/?
It's defined in drivers/mtd/nand and called from board/sunxi so the prototype
needs to go somewhere under include/. It can go in include/configs/sunxi
-common.h with #ifndef __ASSEMBLY__ around it -- or as long as it's limited to
one init func per driver, maybe we could just put it in include/nand.h.
-Scott
next prev parent reply other threads:[~2016-06-06 17:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 15:21 [U-Boot] [PATCH 0/6] sunxi: Add NAND controller driver Boris Brezillon
2016-06-06 15:21 ` [U-Boot] [PATCH 1/6] sunxi: Add missing macros to configure the NAND controller clk Boris Brezillon
2016-06-06 15:21 ` [U-Boot] [PATCH 2/6] mtd: nand: add common DT init code Boris Brezillon
2016-06-06 15:21 ` [U-Boot] [PATCH 3/6] mtd: nand: Add the sunxi NAND controller driver Boris Brezillon
2016-06-06 15:36 ` Hans de Goede
2016-06-06 16:22 ` Boris Brezillon
2016-06-06 17:56 ` Scott Wood [this message]
2016-06-06 18:31 ` Boris Brezillon
2016-06-06 23:54 ` Scott Wood
2016-06-07 5:41 ` Boris Brezillon
2016-06-09 0:44 ` Scott Wood
2016-06-06 15:21 ` [U-Boot] [PATCH 4/6] sun5i: Add NAND controller to the sun5i DTSI Boris Brezillon
2016-06-06 15:21 ` [U-Boot] [PATCH 5/6] mtd: nand: Add a full-id entry for the H27QCG8T2E5R‐BCF NAND Boris Brezillon
2016-06-06 15:21 ` [U-Boot] [PATCH 6/6] sunxi: Enable NAND controller on the CHIP Boris Brezillon
2016-06-06 15:37 ` [U-Boot] [linux-sunxi] [PATCH 0/6] sunxi: Add NAND controller driver Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465235808.22191.86.camel@buserror.net \
--to=oss@buserror.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.