From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH RESEND 06/14] drm/virtio: use drm_crtc_send_vblank_event() Date: Tue, 07 Jun 2016 10:39:15 +0200 Message-ID: <1465288755.14901.4.camel@redhat.com> References: <1465224105-21485-1-git-send-email-gustavo@padovan.org> <1465224105-21485-6-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4970C6E6D7 for ; Tue, 7 Jun 2016 08:39:18 +0000 (UTC) In-Reply-To: <1465224105-21485-6-git-send-email-gustavo@padovan.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Gustavo Padovan Cc: Gustavo Padovan , open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org T24gTW8sIDIwMTYtMDYtMDYgYXQgMTE6NDEgLTAzMDAsIEd1c3Rhdm8gUGFkb3ZhbiB3cm90ZToK PiBGcm9tOiBHdXN0YXZvIFBhZG92YW4gPGd1c3Rhdm8ucGFkb3ZhbkBjb2xsYWJvcmEuY28udWs+ Cj4gCj4gUmVwbGFjZSB0aGUgbGVnYWN5IGRybV9zZW5kX3ZibGFua19ldmVudCgpIHdpdGggdGhl IG5ldyBoZWxwZXIgZnVuY3Rpb24uCj4gCj4gU2lnbmVkLW9mZi1ieTogR3VzdGF2byBQYWRvdmFu IDxndXN0YXZvLnBhZG92YW5AY29sbGFib3JhLmNvLnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9k cm0vdmlydGlvL3ZpcnRncHVfZGlzcGxheS5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL3ZpcnRpby92aXJ0Z3B1X2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS92aXJ0aW8vdmly dGdwdV9kaXNwbGF5LmMKPiBpbmRleCBkNDMwNWRhLi5iYTVlMTFiIDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS92aXJ0aW8vdmlydGdwdV9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vdmlydGlvL3ZpcnRncHVfZGlzcGxheS5jCj4gQEAgLTE1Niw3ICsxNTYsNyBAQCBzdGF0 aWMgaW50IHZpcnRpb19ncHVfcGFnZV9mbGlwKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgCj4g IAlpZiAoZXZlbnQpIHsKPiAgCQlzcGluX2xvY2tfaXJxc2F2ZSgmY3J0Yy0+ZGV2LT5ldmVudF9s b2NrLCBpcnFmbGFncyk7Cj4gLQkJZHJtX3NlbmRfdmJsYW5rX2V2ZW50KGNydGMtPmRldiwgLTEs IGV2ZW50KTsKPiArCQlkcm1fY3J0Y19zZW5kX3ZibGFua19ldmVudChjcnRjLCBldmVudCk7Cj4g IAkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmY3J0Yy0+ZGV2LT5ldmVudF9sb2NrLCBpcnFmbGFn cyk7Cj4gIAl9CgpEYW5pZWwgVmV0dGVyIGhhcyBhIHNlcmllcyBpbiBmbGlnaHQgd2hpY2ggZHJv cHMgdGhlIHdob2xlCnZpcnRpb19ncHVfcGFnZV9mbGlwIGZ1bmN0aW9uIGluIGZhdm9yIG9mIGRy bV9hdG9taWNfaGVscGVyX3BhZ2VfZmxpcC4KCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE2LU1heS8xMDg2OTkuaHRtbAoKY2hlZXJzLAogIEdlcmQK CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754612AbcFGIjW (ORCPT ); Tue, 7 Jun 2016 04:39:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56870 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754598AbcFGIjS convert rfc822-to-8bit (ORCPT ); Tue, 7 Jun 2016 04:39:18 -0400 Message-ID: <1465288755.14901.4.camel@redhat.com> Subject: Re: [PATCH RESEND 06/14] drm/virtio: use drm_crtc_send_vblank_event() From: Gerd Hoffmann To: Gustavo Padovan Cc: dri-devel@lists.freedesktop.org, Gustavo Padovan , David Airlie , "open list:VIRTIO GPU DRIVER" , open list Date: Tue, 07 Jun 2016 10:39:15 +0200 In-Reply-To: <1465224105-21485-6-git-send-email-gustavo@padovan.org> References: <1465224105-21485-1-git-send-email-gustavo@padovan.org> <1465224105-21485-6-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 07 Jun 2016 08:39:17 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mo, 2016-06-06 at 11:41 -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Replace the legacy drm_send_vblank_event() with the new helper function. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c > index d4305da..ba5e11b 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_display.c > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c > @@ -156,7 +156,7 @@ static int virtio_gpu_page_flip(struct drm_crtc *crtc, > > if (event) { > spin_lock_irqsave(&crtc->dev->event_lock, irqflags); > - drm_send_vblank_event(crtc->dev, -1, event); > + drm_crtc_send_vblank_event(crtc, event); > spin_unlock_irqrestore(&crtc->dev->event_lock, irqflags); > } Daniel Vetter has a series in flight which drops the whole virtio_gpu_page_flip function in favor of drm_atomic_helper_page_flip. https://lists.freedesktop.org/archives/dri-devel/2016-May/108699.html cheers, Gerd