All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Fritz <chf.fritz@googlemail.com>
To: Fabio Estevam <festevam@gmail.com>,
	Lucas Stach <l.stach@pengutronix.de>,
	Richard Zhu <hongxing.zhu@nxp.com>
Cc: bhelgaas@google.com, shawnguo@kernel.org,
	linux-pci@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH] PCI: imx6: Add support for MX6SX LDO PCIE domain regulator
Date: Wed, 08 Jun 2016 11:35:23 +0200	[thread overview]
Message-ID: <1465378523.1870.26.camel@googlemail.com> (raw)
In-Reply-To: <1465344472-15703-1-git-send-email-festevam@gmail.com>

Hi Fabio

On Tue, 2016-06-07 at 21:07 -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> MX6SX has an internal LDO regulator for the PCIE domain, which needs
> to be turned on for PCIE functionality.
> 
> Add support for it.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  .../devicetree/bindings/pci/fsl,imx6q-pcie.txt     |  2 ++
>  drivers/pci/host/pci-imx6.c                        | 29 +++++++++++++++++++++-

There was a discussion doing the handling of the regulator inside the PM
backend:

> On Mon, 2016-02-15 at 07:24 +0000, Richard Zhu wrote:
> > As Lucas discussed with me before,  the GPC regulator operations should[n't] be touched in
> > Imx pcie driver at all.  These bits operations should be encapsulate into the PM system,
> >  for example, the regulator driver.

On Thu, 2016-02-18 at 12:59 +0100, Christoph Fritz wrote:
> Ok, for an initial version, I'll just leave the regulator in my
> devicetree enabled. For further enhancements I suppose
> arch/arm/mach-imx/gpc.c needs to get touched?
> 
@Richard and @Lucas: Any further hints on this?

Thanks
 -- Christoph


  reply	other threads:[~2016-06-08  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-08  0:07 [PATCH] PCI: imx6: Add support for MX6SX LDO PCIE domain regulator Fabio Estevam
2016-06-08  9:35 ` Christoph Fritz [this message]
2016-06-12 13:51   ` Fabio Estevam
2016-06-13 10:41     ` Lucas Stach
2016-06-14  3:18       ` Fabio Estevam
2016-06-14  8:37         ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465378523.1870.26.camel@googlemail.com \
    --to=chf.fritz@googlemail.com \
    --cc=bhelgaas@google.com \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=hongxing.zhu@nxp.com \
    --cc=l.stach@pengutronix.de \
    --cc=linux-pci@vger.kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.