From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH v9 11/14] usb: otg: use dev_dbg() instead of VDBG() Date: Wed, 08 Jun 2016 08:10:40 -0700 Message-ID: <1465398640.25087.50.camel@perches.com> References: <1465376626-30122-1-git-send-email-rogerq@ti.com> <1465376626-30122-12-git-send-email-rogerq@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1465376626-30122-12-git-send-email-rogerq-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roger Quadros , peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org Cc: balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, mathias.nyman-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Joao.Pinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org, jun.li-KZfg59tc24xl57MIdRCFDg@public.gmane.org, grygorii.strashko-l0cyMroinI0@public.gmane.org, yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, b-liu-l0cyMroinI0@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-omap@vger.kernel.org On Wed, 2016-06-08 at 12:03 +0300, Roger Quadros wrote: > Now that we have a device reference in struct usb_otg > let's use dev_dbg() for debug messages. dev_vdbg vs dev_dbg The patch subject and commit message don't match the code changes. > diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/us= b-otg-fsm.c [] > @@ -44,8 +37,9 @@ static int otg_set_protocol(struct otg_fsm *fsm, in= t protocol) > =A0 int ret =3D 0; > =A0 > =A0 if (fsm->protocol !=3D protocol) { > - VDBG("Changing role fsm->protocol=3D %d; new protocol=3D %d\n", > - fsm->protocol, protocol); > + dev_vdbg(otg->dev, > + =A0"Changing role fsm->protocol=3D %d; new protocol=3D %d\n", > + =A0fsm->protocol, protocol); etc... -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755420AbcFHPKx (ORCPT ); Wed, 8 Jun 2016 11:10:53 -0400 Received: from smtprelay0157.hostedemail.com ([216.40.44.157]:42879 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753652AbcFHPKv (ORCPT ); Wed, 8 Jun 2016 11:10:51 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3351:3622:3865:3868:3870:3874:4321:5007:6742:7903:10004:10400:10848:11026:11232:11658:11914:12043:12296:12517:12519:12740:13069:13095:13161:13229:13311:13357:13439:13894:14659:14721:21080:21433,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: plot98_5d65a024a9942 X-Filterd-Recvd-Size: 1940 Message-ID: <1465398640.25087.50.camel@perches.com> Subject: Re: [PATCH v9 11/14] usb: otg: use dev_dbg() instead of VDBG() From: Joe Perches To: Roger Quadros , peter.chen@freescale.com Cc: balbi@kernel.org, tony@atomide.com, gregkh@linuxfoundation.org, dan.j.williams@intel.com, mathias.nyman@linux.intel.com, Joao.Pinto@synopsys.com, sergei.shtylyov@cogentembedded.com, jun.li@freescale.com, grygorii.strashko@ti.com, yoshihiro.shimoda.uh@renesas.com, robh@kernel.org, nsekhar@ti.com, b-liu@ti.com, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Date: Wed, 08 Jun 2016 08:10:40 -0700 In-Reply-To: <1465376626-30122-12-git-send-email-rogerq@ti.com> References: <1465376626-30122-1-git-send-email-rogerq@ti.com> <1465376626-30122-12-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2016-06-08 at 12:03 +0300, Roger Quadros wrote: > Now that we have a device reference in struct usb_otg > let's use dev_dbg() for debug messages. dev_vdbg vs dev_dbg The patch subject and commit message don't match the code changes. > diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c [] > @@ -44,8 +37,9 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol) >   int ret = 0; >   >   if (fsm->protocol != protocol) { > - VDBG("Changing role fsm->protocol= %d; new protocol= %d\n", > - fsm->protocol, protocol); > + dev_vdbg(otg->dev, > +  "Changing role fsm->protocol= %d; new protocol= %d\n", > +  fsm->protocol, protocol); etc...