From mboxrd@z Thu Jan 1 00:00:00 1970 From: Deepa Dinamani Subject: [PATCH 12/21] block: rbd: Replace non inode CURRENT_TIME with current_fs_time() Date: Wed, 8 Jun 2016 22:04:56 -0700 Message-ID: <1465448705-25055-13-git-send-email-deepa.kernel@gmail.com> References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: y2038-bounces@lists.linaro.org Sender: "Y2038" To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alex Elder , Sage Weil , Arnd Bergmann , y2038@lists.linaro.org, ceph-devel@vger.kernel.org, Al Viro , Thomas Gleixner , Linus Torvalds , Ilya Dryomov List-Id: ceph-devel.vger.kernel.org Q1VSUkVOVF9USU1FIG1hY3JvIGlzIG5vdCBhcHByb3ByaWF0ZSBmb3IgZmlsZXN5c3RlbXMgYXMg aXQKZG9lc24ndCB1c2UgdGhlIHJpZ2h0IGdyYW51bGFyaXR5IGZvciBmaWxlc3lzdGVtIHRpbWVz dGFtcHMuClVzZSBjdXJyZW50X2ZzX3RpbWUoKSBpbnN0ZWFkLgoKVGhpcyBpcyBhbHNvIGluIHBy ZXBhcmF0aW9uIGZvciB0aGUgcGF0Y2ggdGhhdCB0cmFuc2l0aW9ucwp2ZnMgdGltZXN0YW1wcyB0 byB1c2UgNjQgYml0IHRpbWUgYW5kIGhlbmNlIG1ha2UgdGhlbQp5MjAzOCBzYWZlLiBBcyBwYXJ0 IG9mIHRoZSBlZmZvcnQgY3VycmVudF9mc190aW1lKCkgd2lsbCBiZQpleHRlbmRlZCB0byBkbyBy YW5nZSBjaGVja3MuIEhlbmNlLCBpdCBpcyBuZWNlc3NhcnkgZm9yIGFsbApmaWxlIHN5c3RlbSB0 aW1lc3RhbXBzIHRvIHVzZSBjdXJyZW50X2ZzX3RpbWUoKS4KClNpZ25lZC1vZmYtYnk6IERlZXBh IERpbmFtYW5pIDxkZWVwYS5rZXJuZWxAZ21haWwuY29tPgpDYzogSWx5YSBEcnlvbW92IDxpZHJ5 b21vdkBnbWFpbC5jb20+CkNjOiBTYWdlIFdlaWwgPHNhZ2VAcmVkaGF0LmNvbT4KQ2M6IEFsZXgg RWxkZXIgPGVsZGVyQGtlcm5lbC5vcmc+CkNjOiBjZXBoLWRldmVsQHZnZXIua2VybmVsLm9yZwot LS0KIGRyaXZlcnMvYmxvY2svcmJkLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp b24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2Jsb2NrL3JiZC5jIGIv ZHJpdmVycy9ibG9jay9yYmQuYwppbmRleCA4MTY2NmE1Li40ZGNhZmU0IDEwMDY0NAotLS0gYS9k cml2ZXJzL2Jsb2NrL3JiZC5jCisrKyBiL2RyaXZlcnMvYmxvY2svcmJkLmMKQEAgLTE4ODgsNyAr MTg4OCw3IEBAIHN0YXRpYyB2b2lkIHJiZF9vc2RfcmVxX2Zvcm1hdF93cml0ZShzdHJ1Y3QgcmJk X29ial9yZXF1ZXN0ICpvYmpfcmVxdWVzdCkKIHsKIAlzdHJ1Y3QgY2VwaF9vc2RfcmVxdWVzdCAq b3NkX3JlcSA9IG9ial9yZXF1ZXN0LT5vc2RfcmVxOwogCi0Jb3NkX3JlcS0+cl9tdGltZSA9IENV UlJFTlRfVElNRTsKKwlvc2RfcmVxLT5yX210aW1lID0gY3VycmVudF9mc190aW1lKG9zZF9yZXEt PnJfaW5vZGUtPmlfc2IpOwogCW9zZF9yZXEtPnJfZGF0YV9vZmZzZXQgPSBvYmpfcmVxdWVzdC0+ b2Zmc2V0OwogfQogCi0tIAoxLjkuMQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KWTIwMzggbWFpbGluZyBsaXN0ClkyMDM4QGxpc3RzLmxpbmFyby5vcmcK aHR0cHM6Ly9saXN0cy5saW5hcm8ub3JnL21haWxtYW4vbGlzdGluZm8veTIwMzgK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f66.google.com ([209.85.220.66]:34207 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1426199AbcFIFFy (ORCPT ); Thu, 9 Jun 2016 01:05:54 -0400 From: Deepa Dinamani To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Arnd Bergmann , Thomas Gleixner , Al Viro , Linus Torvalds , y2038@lists.linaro.org, Ilya Dryomov , Sage Weil , Alex Elder , ceph-devel@vger.kernel.org Subject: [PATCH 12/21] block: rbd: Replace non inode CURRENT_TIME with current_fs_time() Date: Wed, 8 Jun 2016 22:04:56 -0700 Message-Id: <1465448705-25055-13-git-send-email-deepa.kernel@gmail.com> In-Reply-To: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: CURRENT_TIME macro is not appropriate for filesystems as it doesn't use the right granularity for filesystem timestamps. Use current_fs_time() instead. This is also in preparation for the patch that transitions vfs timestamps to use 64 bit time and hence make them y2038 safe. As part of the effort current_fs_time() will be extended to do range checks. Hence, it is necessary for all file system timestamps to use current_fs_time(). Signed-off-by: Deepa Dinamani Cc: Ilya Dryomov Cc: Sage Weil Cc: Alex Elder Cc: ceph-devel@vger.kernel.org --- drivers/block/rbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index 81666a5..4dcafe4 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -1888,7 +1888,7 @@ static void rbd_osd_req_format_write(struct rbd_obj_request *obj_request) { struct ceph_osd_request *osd_req = obj_request->osd_req; - osd_req->r_mtime = CURRENT_TIME; + osd_req->r_mtime = current_fs_time(osd_req->r_inode->i_sb); osd_req->r_data_offset = obj_request->offset; } -- 1.9.1