From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Thu, 9 Jun 2016 10:54:45 +0000 Subject: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. In-Reply-To: <20160608143004.GE3363@phenom.ffwll.local> References: <1465388359-8070-1-git-send-email-daniel.vetter@ffwll.ch> <1465388359-8070-3-git-send-email-daniel.vetter@ffwll.ch> <20160608143004.GE3363@phenom.ffwll.local> List-ID: Message-ID: <1465469639.3203.57.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Daniel, On Wed, 2016-06-08@16:30 +0200, Daniel Vetter wrote: > On Wed, Jun 08, 2016@04:14:38PM +0200, Maarten Lankhorst wrote: > > > > Op 08-06-16 om 14:18 schreef Daniel Vetter: > > > > > > The drm core has a nice ready-made helper for exactly the simple case > > > where it should fire on the next vblank. > > > > > > Note that arming the vblank event in _begin is probably too early, and > > > might easily result in the vblank firing too early, before the new set > > > of planes are actually disabled. But that's kinda a minor issue > > > compared to just outright hanging userspace. > > > > > > v2: Be more robust and either arm, when the CRTC is on, or just send > > > the event out right away. > > > > > > Cc: Carlos Palminha > > > Cc: Alexey Brodkin > > > Cc: linux-snps-arc at lists.infradead.org > > > Signed-off-by: Daniel Vetter > > Wouldn't it be better to do this in atomic_flush then? > I'm not going to fix up other people's drivers completely, just enough to > hopefully not break them. If arc also blocks vblank interrupts with the go > bit, then doing this in _begin is correct. Either way it needs hw-specific > knowledge to asses whether it's correct, since doing the vblank event > stuff in _flush is also racy without some prevention. Actually in ARC PGU driver that was one of many other copy-pastes from other drivers. I.e. for me this is another boilerplate and if that's the same for other drivers as well probably that's a good candidate for generalization into something like?drm_helper_crtc_atomic_check(). -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: [PATCH 03/27] drm/arc: Actually bother with handling atomic events. Date: Thu, 9 Jun 2016 10:54:45 +0000 Message-ID: <1465469639.3203.57.camel@synopsys.com> References: <1465388359-8070-1-git-send-email-daniel.vetter@ffwll.ch> <1465388359-8070-3-git-send-email-daniel.vetter@ffwll.ch> <20160608143004.GE3363@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-7" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20160608143004.GE3363@phenom.ffwll.local> Content-Language: en-US Content-ID: <57D9C0BCF6475F4496C12EC0ABCF122B@internal.synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: "daniel@ffwll.ch" Cc: "daniel.vetter@ffwll.ch" , "Alexey.Brodkin@synopsys.com" , "maarten.lankhorst@linux.intel.com" , "CARLOS.PALMINHA@synopsys.com" , "dri-devel@lists.freedesktop.org" , "daniel.vetter@intel.com" , "linux-snps-arc@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLAoKT24gV2VkLCAyMDE2LTA2LTA4IGF0IDE2OjMwICstMDIwMCwgRGFuaWVsIFZl dHRlciB3cm90ZToKPiBPbiBXZWQsIEp1biAwOCwgMjAxNiBhdCAwNDoxNDozOFBNICstMDIwMCwg TWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPiAKPiA+IE9wIDA4LTA2LTE2IG9tIDE0OjE4IHNj aHJlZWYgRGFuaWVsIFZldHRlcjoKPiA+ID4gCj4gPiA+IFRoZSBkcm0gY29yZSBoYXMgYSBuaWNl IHJlYWR5LW1hZGUgaGVscGVyIGZvciBleGFjdGx5IHRoZSBzaW1wbGUgY2FzZQo+ID4gPiB3aGVy ZSBpdCBzaG91bGQgZmlyZSBvbiB0aGUgbmV4dCB2YmxhbmsuCj4gPiA+IAo+ID4gPiBOb3RlIHRo YXQgYXJtaW5nIHRoZSB2YmxhbmsgZXZlbnQgaW4gX2JlZ2luIGlzIHByb2JhYmx5IHRvbyBlYXJs eSwgYW5kCj4gPiA+IG1pZ2h0IGVhc2lseSByZXN1bHQgaW4gdGhlIHZibGFuayBmaXJpbmcgdG9v IGVhcmx5LCBiZWZvcmUgdGhlIG5ldyBzZXQKPiA+ID4gb2YgcGxhbmVzIGFyZSBhY3R1YWxseSBk aXNhYmxlZC4gQnV0IHRoYXQncyBraW5kYSBhIG1pbm9yIGlzc3VlCj4gPiA+IGNvbXBhcmVkIHRv IGp1c3Qgb3V0cmlnaHQgaGFuZ2luZyB1c2Vyc3BhY2UuCj4gPiA+IAo+ID4gPiB2MjogQmUgbW9y ZSByb2J1c3QgYW5kIGVpdGhlciBhcm0sIHdoZW4gdGhlIENSVEMgaXMgb24sIG9yIGp1c3Qgc2Vu ZAo+ID4gPiB0aGUgZXZlbnQgb3V0IHJpZ2h0IGF3YXkuCj4gPiA+IAo+ID4gPiBDYzogQ2FybG9z IFBhbG1pbmhhIDxwYWxtaW5oYUBzeW5vcHN5cy5jb20+Cj4gPiA+IENjOiBBbGV4ZXkgQnJvZGtp biA8YWJyb2RraW5Ac3lub3BzeXMuY29tPgo+ID4gPiBDYzogbGludXgtc25wcy1hcmNAbGlzdHMu aW5mcmFkZWFkLm9yZwo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwu dmV0dGVyQGludGVsLmNvbT4KPiA+IFdvdWxkbid0IGl0IGJlIGJldHRlciB0byBkbyB0aGlzIGlu IGF0b21pY19mbHVzaCB0aGVuPwo+IEknbSBub3QgZ29pbmcgdG8gZml4IHVwIG90aGVyIHBlb3Bs ZSdzIGRyaXZlcnMgY29tcGxldGVseSwganVzdCBlbm91Z2ggdG8KPiBob3BlZnVsbHkgbm90IGJy ZWFrIHRoZW0uIElmIGFyYyBhbHNvIGJsb2NrcyB2YmxhbmsgaW50ZXJydXB0cyB3aXRoIHRoZSBn bwo+IGJpdCwgdGhlbiBkb2luZyB0aGlzIGluIF9iZWdpbiBpcyBjb3JyZWN0LiBFaXRoZXIgd2F5 IGl0IG5lZWRzIGh3LXNwZWNpZmljCj4ga25vd2xlZGdlIHRvIGFzc2VzIHdoZXRoZXIgaXQncyBj b3JyZWN0LCBzaW5jZSBkb2luZyB0aGUgdmJsYW5rIGV2ZW50Cj4gc3R1ZmYgaW4gX2ZsdXNoIGlz IGFsc28gcmFjeSB3aXRob3V0IHNvbWUgcHJldmVudGlvbi4KCkFjdHVhbGx5IGluIEFSQyBQR1Ug ZHJpdmVyIHRoYXQgd2FzIG9uZSBvZiBtYW55IG90aGVyIGNvcHktcGFzdGVzIGZyb20Kb3RoZXIg ZHJpdmVycy4gSS5lLiBmb3IgbWUgdGhpcyBpcyBhbm90aGVyIGJvaWxlcnBsYXRlIGFuZCBpZiB0 aGF0J3MgdGhlCnNhbWUgZm9yIG90aGVyIGRyaXZlcnMgYXMgd2VsbCBwcm9iYWJseSB0aGF0J3Mg YSBnb29kIGNhbmRpZGF0ZSBmb3IKZ2VuZXJhbGl6YXRpb24gaW50byBzb21ldGhpbmcgbGlrZStB S0EtZHJtX2hlbHBlcl9jcnRjX2F0b21pY19jaGVjaygpLgoKLUFsZXhleQpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1zbnBzLWFyYyBtYWlsaW5n IGxpc3QKbGludXgtc25wcy1hcmNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXNucHMtYXJj