From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keller, Jacob E Date: Thu, 9 Jun 2016 18:57:18 +0000 Subject: [Intel-wired-lan] [PATCH] fm10k: restore D0 power state upon probe In-Reply-To: References: <20160608002043.10367-1-jacob.e.keller@intel.com> <02874ECE860811409154E81DA85FBB5857AE09FD@ORSMSX115.amr.corp.intel.com> <02874ECE860811409154E81DA85FBB5857AE0C0D@ORSMSX115.amr.corp.intel.com> <02874ECE860811409154E81DA85FBB5857AE0C33@ORSMSX115.amr.corp.intel.com> <02874ECE860811409154E81DA85FBB5857AE19DE@ORSMSX115.amr.corp.intel.com> Message-ID: <1465498638.11216.1.camel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Thu, 2016-06-09 at 10:54 -0700, Alexander Duyck wrote: > No, it will but you have to actually be re-enabling the device to > trigger it. > > You might try replacing the call to pci_enable_device_mem with > pci_reenable_device and see if that works for you.??I suspect this is > probably a bug that is common in many of the drivers out there. > > - Alex Changing the pci_enable_device_mem() to a pci_reenable_device() inside the .io_slot_reset seems to have worked, and is much cleaner than my alternative approach. I think this is the right way since we aren't really wanting to disable the device in this section and matches up with what the .slot_reset wants without breaking other flows. I'll have a patch for that in a bit. Thanks, Jake