From: "Krzysztof Błaszkowski" <kb@sysmikro.com.pl>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, Carlos Maiolino <cmaiolino@redhat.com>
Subject: Re: freevxfs: hp-ux support. ( 1cce17017970c07) patchset 2/4
Date: Fri, 10 Jun 2016 16:47:04 +0200 [thread overview]
Message-ID: <1465570024.5573.25.camel@linux-q3cb.site> (raw)
this is far more important and I decided that it is enough to use
inode_init_once() in alloc_inode() because this is the only one place
which uses kmem_cache_alloc() thus the callback for kmem_cache_create()
is not required.
>From 36de33b8a96c5a1df89dc5b0b01aaa2f2ab44b7d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krzysztof=20B=C5=82aszkowski?= <kb@sysmikro.com.pl>
Date: Fri, 10 Jun 2016 13:13:31 +0200
Subject: [PATCH 2/4] fix lack of inode initialization
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
there is nothing worse than just allocated inode without being initialized _once()
Signed-off-by: Krzysztof Błaszkowski <kb@sysmikro.com.pl>
---
fs/freevxfs/vxfs_super.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/freevxfs/vxfs_super.c b/fs/freevxfs/vxfs_super.c
index e5eef14..455ce5b 100644
--- a/fs/freevxfs/vxfs_super.c
+++ b/fs/freevxfs/vxfs_super.c
@@ -127,6 +127,7 @@ static struct inode *vxfs_alloc_inode(struct super_block *sb)
vi = kmem_cache_alloc(vxfs_inode_cachep, GFP_KERNEL);
if (!vi)
return NULL;
+ inode_init_once(&vi->vfs_inode);
return &vi->vfs_inode;
}
--
2.8.3
--
Krzysztof Blaszkowski
reply other threads:[~2016-06-10 14:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465570024.5573.25.camel@linux-q3cb.site \
--to=kb@sysmikro.com.pl \
--cc=cmaiolino@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.