All of lore.kernel.org
 help / color / mirror / Atom feed
From: "André Draszik" <git@andred.net>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH 2/2] uclibc: never build with SSP
Date: Fri, 10 Jun 2016 16:12:13 +0100	[thread overview]
Message-ID: <1465571533-21604-2-git-send-email-git@andred.net> (raw)
In-Reply-To: <1465571533-21604-1-git-send-email-git@andred.net>

From: André Draszik <adraszik@tycoint.com>

This doesn't work, as the initial gcc that is used for compiling
uclibc doesn't have support for SSP yet (since that will only
be available once uclibc has been compiled). Since during that
same compilation step uclibc is trying to build its own utils
those are failing to compile with SSP enabled as the
initial gcc doesn't have access to the required libraries,
yet.

We never used to set UCLIBC_BUILD_SSP in the past, this was
only changed as part of the upgrade to uclibc-ng in
commit 63bdadc (uclibc: Switch to using uclibc-ng), so here
we now simply restore the previous behaviour.

Note that we still enable SSP support inside uclibc for
everybody else to use, though.

Signed-off-by: André Draszik <adraszik@tycoint.com>
---
 meta/recipes-core/uclibc/uclibc-config.inc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-core/uclibc/uclibc-config.inc b/meta/recipes-core/uclibc/uclibc-config.inc
index ed7b522..8b9e41c 100644
--- a/meta/recipes-core/uclibc/uclibc-config.inc
+++ b/meta/recipes-core/uclibc/uclibc-config.inc
@@ -119,7 +119,6 @@ def features_to_uclibc_settings(d):
     uclibc_cfg('thumb-interwork', distro_features,'USE_BX', cnf, rem)
     uclibc_cfg('xattr',     distro_features, 'UCLIBC_HAS_XATTR', cnf, rem)
     uclibc_cfg('ssp',       distro_features, 'UCLIBC_HAS_SSP', cnf, rem)
-    uclibc_cfg('ssp',       distro_features, 'UCLIBC_BUILD_SSP', cnf, rem)
     uclibc_cfg('argp',       distro_features, 'UCLIBC_HAS_ARGP', cnf, rem)
     uclibc_cfg('libc-posix-clang-wchar',  distro_features,'UCLIBC_HAS_WCHAR', cnf, rem)
     return "\n".join(cnf), "\n".join(rem)
-- 
2.8.1



  reply	other threads:[~2016-06-10 15:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-10 15:12 [PATCH 1/2] uclibc: no need for CONFIG_MIPS_ISA_xxx config options André Draszik
2016-06-10 15:12 ` André Draszik [this message]
2016-06-16  0:20   ` [PATCH 2/2] uclibc: never build with SSP Khem Raj
2016-06-20 14:48     ` André Draszik
2016-06-20 15:21       ` André Draszik
2016-06-21 16:12       ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1465571533-21604-2-git-send-email-git@andred.net \
    --to=git@andred.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.