From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] ethdev: fix ABI breakage in lro code
Date: Mon, 13 Jul 2015 12:46:17 +0200
Message-ID: <1465595.fVxK4oazvN@xps13>
References: <1436783185-8279-1-git-send-email-john.mcnamara@intel.com>
 <20150713104218.GB9631@hmsreliant.think-freely.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Chao Zhu <chaozhu@linux.vnet.ibm.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 9ACEC5955
 for <dev@dpdk.org>; Mon, 13 Jul 2015 12:47:31 +0200 (CEST)
Received: by wicmv11 with SMTP id mv11so58221739wic.1
 for <dev@dpdk.org>; Mon, 13 Jul 2015 03:47:31 -0700 (PDT)
In-Reply-To: <20150713104218.GB9631@hmsreliant.think-freely.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-13 06:42, Neil Horman:
> On Mon, Jul 13, 2015 at 11:26:25AM +0100, John McNamara wrote:
> > Fix for ABI breakage introduced in LRO addition. Moves
> > lro bitfield to the end of the struct/member.
> > 
> > Fixes: 8eecb3295aed (ixgbe: add LRO support)
> > 
> > Signed-off-by: John McNamara <john.mcnamara@intel.com>
> > ---
> >  lib/librte_ether/rte_ethdev.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> > index 79bde89..1c3ace1 100644
> > --- a/lib/librte_ether/rte_ethdev.h
> > +++ b/lib/librte_ether/rte_ethdev.h
> > @@ -1578,9 +1578,9 @@ struct rte_eth_dev_data {
> >  	uint8_t port_id;           /**< Device [external] port identifier. */
> >  	uint8_t promiscuous   : 1, /**< RX promiscuous mode ON(1) / OFF(0). */
> >  		scattered_rx : 1,  /**< RX of scattered packets is ON(1) / OFF(0) */
> > -		lro          : 1,  /**< RX LRO is ON(1) / OFF(0) */
> >  		all_multicast : 1, /**< RX all multicast mode ON(1) / OFF(0). */
> > -		dev_started : 1;   /**< Device state: STARTED(1) / STOPPED(0). */
> > +		dev_started : 1,   /**< Device state: STARTED(1) / STOPPED(0). */
> > +		lro         : 1;   /**< RX LRO is ON(1) / OFF(0) */
> >  };
> >  
> >  /**
> I presume the ABI checker stopped complaining about this with the patch, yes?
> 
> Also, it would be great if someone could check this on ppc or a ppc cross
> compile, as I recall bitfields follow endianess order.

+ Chao, IBM POWER maintainer.