Re: [PATCH 0/6] Intel Integrated Sensor Hub Support (ISH)

[Atri Bhattacharya <badshah400@aim.com>]

[-- Attachment #1: Type: text/plain, Size: 2280 bytes --]

Hi Srinivas,

On Sat, 2016-06-11 at 05:13 -0700, Srinivas Pandruvada wrote:
> Starting from Cherrytrail, multiple generation of Intel processors
> offers
> on package sensor hub. Several recent tablets, 2-in-1 convertible
> laptops
> are using ISH instead of external sensor hubs. This resulted in lack
> of
> support of sensor function like device rotation and auto backlight
> adjustment.
> In addition, depending on the OEM implementation, support of ISH is
> required
> to support low power sleep states.
> 
> The support of ISH on Linux platforms is not new. Android platforms
> with
> Intel SoCs had this support for a while submitted by Daniel Drubin. 
> This patcheset is reusing most of those changes with  clean up and
> removing Android platform specific changes.
> 
> The user mode ABI is still same as external sensor hubs using Linux
> IIO. So existing user mode software should still work.
> This series primarily brings in new HID transport used in ISH.
> 
> Thanks to the community members who tested RFC patches and provided
> feedback.
> 
> For users testing on Linux distributions using IIO sensor proxy,
> a short term work around is required till we have debugged this
> issue.
> In systemd unit file iio-sensor-proxy.service
> In the section "[Unit]" add
> After=multi-user.target
> 

Thank you so much for the updated patchset. It works! Auto
rotation and brightness work out of a cold boot and also after waking
up from suspend. Suspend/Wakeup is also back to usual speed.

One minor gripe I have is that the brightness seems to be set to 100%
every time upon reboot. So if I set brightness to 50% e.g., and reboot,
the brightness is reset to 100% again (not initially but right after
iio-sensor-monitor loads). Of course, this might not have anything to
do with the driver, but I just thought I should mention it here as long
as I am not sure about the cause. I attach journal logs for your
perusal.

I have now tested the patches both against kernel 4.7rc2 and 4.6.2, and
it works just fine in both cases. My test device is a Lenovo Thinkpad
Yoga 260.

Thanks and best wishes.
-- 
Atri Bhattacharya
Sat 11 Jun 15:00:41 CEST 2016

Sent from openSUSE Tumbleweed (20160609) (x86_64) on my laptop.

[-- Attachment #2: journal-ish--success.log.tar.bz2 --]
[-- Type: application/x-bzip-compressed-tar, Size: 19596 bytes --]