Re: [PATCH 10/10] runqueue: report progress for "Preparing RunQueue" step

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2016-06-13 at 14:52 +1200, Paul Eggleton wrote:
> @@ -1119,14 +1150,19 @@ class RunQueue:
>  
>          if self.state is runQueuePrepare:
>              self.rqexe = RunQueueExecuteDummy(self)
> +            self.rqdata.init_progress_reporter = bb.progress.MultiStageProcessProgressReporter(self.cooker.data,
> +                                                            "Initialising tasks",
> +                                                            [27, 870, 3, 33, 1, 3, 3, 2, 3, 6, 1, 13, 1, 1, 132, 32, 1, 61, 1, 13, 2, 243, 151, 299, 81, 1, 15, 72])
>              if self.rqdata.prepare() == 0:
>                  self.state = runQueueComplete
>              else:
>                  self.state = runQueueSceneInit
> +                self.rqdata.init_progress_reporter.next_stage()
>  

I appreciate the difficulty in figuring some of this out and the
changes look quite neat on the most part. I am however very worried by
the above from a code maintenance standpoint.

If for example I add or remove a step in runqueue, how do I know where
in this array to make a change? How do I calculate what the new
weighting should be?

I did wonder if next_stage() should pass the number instead, that way
at least the call site would be clearer. It doesn't solve the problem
of knowing how many steps there are, or what these weights mean or how
to recalculate them in the future.

Any thoughts on that?

Cheers,

Richard