From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH] virtio-gpu: use src not crtc Date: Tue, 14 Jun 2016 14:57:33 +0200 Message-ID: <1465909053.6693.63.camel@redhat.com> References: <1464699172-26755-1-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 604E96E748 for ; Tue, 14 Jun 2016 12:57:36 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau Cc: open list , dri-devel@lists.freedesktop.org, "open list:VIRTIO GPU DRIVER" List-Id: dri-devel@lists.freedesktop.org T24gRGksIDIwMTYtMDYtMTQgYXQgMTI6MTMgKzAyMDAsIE1hcmMtQW5kcsOpIEx1cmVhdSB3cm90 ZToKPiBIaQo+IAo+IE9uIFR1ZSwgTWF5IDMxLCAyMDE2IGF0IDI6NTIgUE0sIEdlcmQgSG9mZm1h bm4gPGtyYXhlbEByZWRoYXQuY29tPiB3cm90ZToKPiA+IFBpY2sgdXAgdGhlIGNvcnJlY3Qgc291 cmNlIHJlY3RhbmdsZSBmcm9tIGZyYW1lYnVmZmVyLgo+ID4gV2l0aG91dCB0aGlzIG11bHRpaGVh ZCBzZXR1cHMgYXJlIG5vdCB3b3JraW5nIGNvcnJlY3RseS4KPiA+Cj4gPiBTaWduZWQtb2ZmLWJ5 OiBHZXJkIEhvZmZtYW5uIDxrcmF4ZWxAcmVkaGF0LmNvbT4KPiAKPiBSZXZpZXdlZC1ieTogTWFy Yy1BbmRyw6kgTHVyZWF1IDxtYXJjYW5kcmUubHVyZWF1QHJlZGhhdC5jb20+Cj4gCj4gQWRkaXRp b25hbGx5LCBJIGhhZCB0byBtb2RpZnkgdGhlIHBhZ2VfZmxpcCgpIGZ1bmN0aW9uIHRvIHRha2Ug dGhlCj4gcGxhbmUgc291cmNlIGNvb3JkaW5hdGVzIGZvciB2aXJnbC8zZCBtdWx0aWhlYWQgdG8g d29yay4gRmVlbCBmcmVlIHRvCj4gc3F1YXNoLgoKVGhpcyBpcyBpbiBwcm9ncmVzcyBvZiBiZWlu ZyBzb3J0ZWQsIGJ5IGRyb3BwaW5nIHRoZQp2aXJ0aW9fZ3B1X3BhZ2VfZmxpcCBmdW5jdGlvbiBh bHRvZ2V0aGVyIGluIGZhdm9yIG9mIGF0b21pYyBoZWxwZXJzLAp3aGljaCB3aWxsIHVzZSB0aGUg KGFscmVhZHkgZml4ZWQpIHBsYW5lIGNhbGxiYWNrcyBpbnN0ZWFkLgoKU2VlIG5vbmJsb2NraW5n IGNvbW1pdCBzdXBwb3J0IHBhdGNoZXMgYnkgRGFuaWVsIFZldHRlciBvbiB0aGlzIGxpc3QuCgpj aGVlcnMsCiAgR2VyZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751764AbcFNM5h (ORCPT ); Tue, 14 Jun 2016 08:57:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46238 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751153AbcFNM5g convert rfc822-to-8bit (ORCPT ); Tue, 14 Jun 2016 08:57:36 -0400 Message-ID: <1465909053.6693.63.camel@redhat.com> Subject: Re: [PATCH] virtio-gpu: use src not crtc From: Gerd Hoffmann To: =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau Cc: dri-devel@lists.freedesktop.org, David Airlie , "open list:VIRTIO GPU DRIVER" , open list Date: Tue, 14 Jun 2016 14:57:33 +0200 In-Reply-To: References: <1464699172-26755-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Mime-Version: 1.0 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 14 Jun 2016 12:57:36 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Di, 2016-06-14 at 12:13 +0200, Marc-André Lureau wrote: > Hi > > On Tue, May 31, 2016 at 2:52 PM, Gerd Hoffmann wrote: > > Pick up the correct source rectangle from framebuffer. > > Without this multihead setups are not working correctly. > > > > Signed-off-by: Gerd Hoffmann > > Reviewed-by: Marc-André Lureau > > Additionally, I had to modify the page_flip() function to take the > plane source coordinates for virgl/3d multihead to work. Feel free to > squash. This is in progress of being sorted, by dropping the virtio_gpu_page_flip function altogether in favor of atomic helpers, which will use the (already fixed) plane callbacks instead. See nonblocking commit support patches by Daniel Vetter on this list. cheers, Gerd