From: "Jiang, Dave" <dave.jiang@intel.com>
To: "Allen.Hubbe@emc.com" <Allen.Hubbe@emc.com>,
"logang@deltatee.com" <logang@deltatee.com>,
"jdmason@kudzu.us" <jdmason@kudzu.us>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shuahkh@osg.samsung.com" <shuahkh@osg.samsung.com>,
"sudipm.mukherjee@gmail.com" <sudipm.mukherjee@gmail.com>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-ntb@googlegroups.com" <linux-ntb@googlegroups.com>
Subject: Re: [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down.
Date: Wed, 15 Jun 2016 21:33:52 +0000 [thread overview]
Message-ID: <1466026416.16234.262.camel@intel.com> (raw)
In-Reply-To: <b1aa9e9977b992621452812f744ff7827ca4f28c.1466025130.git.logang@deltatee.com>
On Wed, 2016-06-15 at 15:26 -0600, Logan Gunthorpe wrote:
> When the link goes down, the link_is_up flag did not return to
> false. This could have caused some subtle corner case bugs
> when the link goes up and down quickly.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Dave Jiang <dave.jiang@intel.com>
And all the other ntb_perf patches since there were no additional
changes.
> ---
> drivers/ntb/test/ntb_perf.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/ntb/test/ntb_perf.c
> b/drivers/ntb/test/ntb_perf.c
> index f0784e5..ae9d1b2 100644
> --- a/drivers/ntb/test/ntb_perf.c
> +++ b/drivers/ntb/test/ntb_perf.c
> @@ -557,6 +557,8 @@ static void perf_link_cleanup(struct work_struct
> *work)
>
> if (!perf->link_is_up)
> cancel_delayed_work_sync(&perf->link_work);
> +
> + perf->link_is_up = false;
> }
>
> static int perf_setup_mw(struct ntb_dev *ntb, struct perf_ctx *perf)
> --
> 2.1.4
>
next prev parent reply other threads:[~2016-06-15 21:33 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 21:26 [PATCH v3 00/10] NTB Selftest Script Logan Gunthorpe
2016-06-15 21:26 ` [PATCH v3 01/10] ntb_perf: Schedule based on time not on performance Logan Gunthorpe
2016-06-15 21:26 ` [PATCH v3 02/10] ntb_perf: Improve thread handling to increase robustness Logan Gunthorpe
2016-06-15 21:26 ` [PATCH v3 03/10] ntb_perf: Return results by reading the run file Logan Gunthorpe
2016-06-15 21:26 ` [PATCH v3 04/10] ntb_perf: Wait for link before running test Logan Gunthorpe
2016-06-15 21:26 ` [PATCH v3 05/10] ntb_tool: BUG: Ensure the buffer size is large enough to return all spads Logan Gunthorpe
2016-06-15 21:26 ` [PATCH v3 06/10] ntb_tool: Postpone memory window initialization for the user Logan Gunthorpe
2016-06-15 21:53 ` Allen Hubbe
2016-06-15 21:53 ` Allen Hubbe
2016-06-15 21:26 ` [PATCH v3 07/10] ntb_tool: Add link status and files to debugfs Logan Gunthorpe
2016-06-15 21:48 ` Allen Hubbe
2016-06-15 21:48 ` Allen Hubbe
2016-06-15 21:26 ` [PATCH v3 08/10] ntb_pingpong: Add a debugfs file to get the ping count Logan Gunthorpe
2016-06-15 21:48 ` Allen Hubbe
2016-06-15 21:48 ` Allen Hubbe
2016-06-15 21:26 ` [PATCH v3 09/10] ntb_test: Add a selftest script for the NTB subsystem Logan Gunthorpe
2016-06-15 21:49 ` Allen Hubbe
2016-06-15 21:49 ` Allen Hubbe
2016-06-15 21:54 ` Logan Gunthorpe
2016-06-15 22:17 ` Allen Hubbe
2016-06-15 22:17 ` Allen Hubbe
2016-06-15 22:30 ` Logan Gunthorpe
2016-06-15 21:26 ` [PATCH v3 10/10] ntb_perf: clear link_is_up flag when the link goes down Logan Gunthorpe
2016-06-15 21:33 ` Jiang, Dave [this message]
2016-06-15 22:20 ` Logan Gunthorpe
2016-06-15 22:24 ` Jiang, Dave
2016-06-15 23:11 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466026416.16234.262.camel@intel.com \
--to=dave.jiang@intel.com \
--cc=Allen.Hubbe@emc.com \
--cc=arnd@arndb.de \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=logang@deltatee.com \
--cc=shuahkh@osg.samsung.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.