All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Anatoly Gusev <avg.tolik@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] msmouse: send short messages if possible.
Date: Thu, 16 Jun 2016 10:41:58 +0200	[thread overview]
Message-ID: <1466066518.7715.19.camel@redhat.com> (raw)
In-Reply-To: <CAFEAcA_bPkpmb38Wqiiaer7HYOE5i7AqyfbgpLgDsVqay30Ouw@mail.gmail.com>

  Hi,

> > -    if (mouse->outlen <= sizeof(mouse->outbuf) - 4) {
> > +    if (mouse->outlen <= sizeof(mouse->outbuf) - count) {
> >          /* We always send the packet of, so that we do not have to keep track
> >             of previous state of the middle button. This can potentially confuse
> >             some very old drivers for two button mice though. */
> 
> Is this comment now out of date ?

Yes.  I'll drop it in v2. 

cheers,
  Gerd

      reply	other threads:[~2016-06-16  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16  8:07 [Qemu-devel] [PATCH 0/2] more msmouse fixes Gerd Hoffmann
2016-06-16  8:07 ` [Qemu-devel] [PATCH 1/2] msmouse: switch to new input interface Gerd Hoffmann
2016-06-16  8:07 ` [Qemu-devel] [PATCH 2/2] msmouse: send short messages if possible Gerd Hoffmann
2016-06-16  8:13   ` Peter Maydell
2016-06-16  8:41     ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466066518.7715.19.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=avg.tolik@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.