All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH RFC 0/3] perf script: Add callindent option
Date: Thu, 16 Jun 2016 15:34:31 +0300	[thread overview]
Message-ID: <1466080474-22576-1-git-send-email-adrian.hunter@intel.com> (raw)

Hi

Andi Kleen sent a couple of patches to add a callindent option to
perf script. If Andi is agreeable, I would like to propose an
alternative implementation.

While there are some differences in the resulting output, the main
differences are:

 1. Tell the decoder to feed branches to the thread stack, which has the
 advantage that it happens before branch filtering and so can be used
 with different itrace options (e.g. it still works when only showing
 calls, even though the thread stack needs to see calls and returns). Also
 it does not conflict with using the thread stack to get callchains.

 2. Print "call" or "ret" instead of using a different event


Adrian Hunter (3):
      perf: script: Fix documentation of '-f' when it should be '-F'
      perf auxtrace: Add option to feed branches to the thread stack
      perf script: Add callindent option

 tools/perf/Documentation/perf-script.txt | 26 +++++++-----
 tools/perf/builtin-script.c              | 70 ++++++++++++++++++++++++++++++++
 tools/perf/util/auxtrace.h               |  2 +
 tools/perf/util/intel-bts.c              | 22 +++++++---
 tools/perf/util/intel-pt.c               |  5 ++-
 tools/perf/util/thread-stack.c           |  7 ++++
 tools/perf/util/thread-stack.h           |  1 +
 7 files changed, 117 insertions(+), 16 deletions(-)


Regards
Adrian

             reply	other threads:[~2016-06-16 12:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16 12:34 Adrian Hunter [this message]
2016-06-16 12:34 ` [PATCH RFC 1/3] perf: script: Fix documentation of '-f' when it should be '-F' Adrian Hunter
2016-06-16 19:53   ` Arnaldo Carvalho de Melo
2016-06-16 12:34 ` [PATCH RFC 2/3] perf auxtrace: Add option to feed branches to the thread stack Adrian Hunter
2016-06-16 12:34 ` [PATCH RFC 3/3] perf script: Add callindent option Adrian Hunter
2016-06-17  8:22   ` [PATCH RFC V2 " Adrian Hunter
2016-06-20 23:50     ` Andi Kleen
2016-06-16 16:37 ` [PATCH RFC 0/3] " Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466080474-22576-1-git-send-email-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.