From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Thu, 16 Jun 2016 16:47:08 +0000 Subject: of_reserved_mem_device_init_by_idx() returns -EINVAL if "memory-region" is missing List-ID: Message-ID: <1466095574.4442.53.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Marek, We used to use?of_reserved_mem_device_init() in such a context in GPU drivers: -------------------->8------------------- /* Get the optional framebuffer memory resource */ ret = of_reserved_mem_device_init(drm->dev); if (ret && ret != -ENODEV) return ret; -------------------->8------------------- The point is we may have a dedicated reserved memory area or may not have (depends on a particular .dts). Our expectation is if reserved memory area is missing then of_reserved_mem_device_init() just returns -ENODEV and it used to work like this. Now with your commit?59ce4039727e "of: reserved_mem: add support for using more than one region for given device" behavior is different.?of_reserved_mem_device_init_by_idx() has this: -------------------->8------------------- target = of_parse_phandle(np, "memory-region", idx); if (!target) return -EINVAL; -------------------->8------------------- So I'm wondering which part should be fixed: ?1)?of_reserved_mem itself or ?2) users of of_reserved_mem_device_init() Any thoughts? Regards, Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: of_reserved_mem_device_init_by_idx() returns -EINVAL if "memory-region" is missing Date: Thu, 16 Jun 2016 16:47:08 +0000 Message-ID: <1466095574.4442.53.camel@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-7" Content-Transfer-Encoding: base64 Return-path: Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: "m.szyprowski@samsung.com" Cc: "robh@kernel.org" , "s.nawrocki@samsung.com" , "airlied@linux.ie" , "Liviu.Dudau@arm.com" , "dri-devel@lists.freedesktop.org" , "daniel@ffwll.ch" , "linux-snps-arc@lists.infradead.org" List-Id: dri-devel@lists.freedesktop.org SGkgTWFyZWssCgpXZSB1c2VkIHRvIHVzZStBS0Etb2ZfcmVzZXJ2ZWRfbWVtX2RldmljZV9pbml0 KCkgaW4gc3VjaCBhIGNvbnRleHQgaW4gR1BVIGRyaXZlcnM6Ci0tLS0tLS0tLS0tLS0tLS0tLS0t PjgtLS0tLS0tLS0tLS0tLS0tLS0tCgkvKiBHZXQgdGhlIG9wdGlvbmFsIGZyYW1lYnVmZmVyIG1l bW9yeSByZXNvdXJjZSAqLwoJcmV0ID0gb2ZfcmVzZXJ2ZWRfbWVtX2RldmljZV9pbml0KGRybS0+ ZGV2KTsKCWlmIChyZXQgJiYgcmV0ICE9IC1FTk9ERVYpCgkJcmV0dXJuIHJldDsKLS0tLS0tLS0t LS0tLS0tLS0tLS0+OC0tLS0tLS0tLS0tLS0tLS0tLS0KClRoZSBwb2ludCBpcyB3ZSBtYXkgaGF2 ZSBhIGRlZGljYXRlZCByZXNlcnZlZCBtZW1vcnkgYXJlYSBvciBtYXkgbm90IGhhdmUgKGRlcGVu ZHMgb24gYSBwYXJ0aWN1bGFyIC5kdHMpLgpPdXIgZXhwZWN0YXRpb24gaXMgaWYgcmVzZXJ2ZWQg bWVtb3J5IGFyZWEgaXMgbWlzc2luZyB0aGVuIG9mX3Jlc2VydmVkX21lbV9kZXZpY2VfaW5pdCgp Cmp1c3QgcmV0dXJucyAtRU5PREVWIGFuZCBpdCB1c2VkIHRvIHdvcmsgbGlrZSB0aGlzLgoKTm93 IHdpdGggeW91ciBjb21taXQrQUtBLTU5Y2U0MDM5NzI3ZSAib2Y6IHJlc2VydmVkX21lbTogYWRk IHN1cHBvcnQgZm9yIHVzaW5nIG1vcmUgdGhhbiBvbmUgcmVnaW9uIGZvciBnaXZlbiBkZXZpY2Ui CmJlaGF2aW9yIGlzIGRpZmZlcmVudC4rQUtBLW9mX3Jlc2VydmVkX21lbV9kZXZpY2VfaW5pdF9i eV9pZHgoKSBoYXMgdGhpczoKLS0tLS0tLS0tLS0tLS0tLS0tLS0+OC0tLS0tLS0tLS0tLS0tLS0t LS0KCXRhcmdldCA9IG9mX3BhcnNlX3BoYW5kbGUobnAsICJtZW1vcnktcmVnaW9uIiwgaWR4KTsK CWlmICghdGFyZ2V0KQoJCXJldHVybiAtRUlOVkFMOwotLS0tLS0tLS0tLS0tLS0tLS0tLT44LS0t LS0tLS0tLS0tLS0tLS0tLQoKU28gSSdtIHdvbmRlcmluZyB3aGljaCBwYXJ0IHNob3VsZCBiZSBm aXhlZDoKK0FLQS0xKStBS0Etb2ZfcmVzZXJ2ZWRfbWVtIGl0c2VsZiBvcgorQUtBLTIpIHVzZXJz IG9mIG9mX3Jlc2VydmVkX21lbV9kZXZpY2VfaW5pdCgpCgpBbnkgdGhvdWdodHM/CgpSZWdhcmRz LApBbGV4ZXkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtc25wcy1hcmMgbWFpbGluZyBsaXN0CmxpbnV4LXNucHMtYXJjQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1z bnBzLWFyYw==