From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754156AbcFPSLv (ORCPT ); Thu, 16 Jun 2016 14:11:51 -0400 Received: from smtprelay0123.hostedemail.com ([216.40.44.123]:51764 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752815AbcFPSLt (ORCPT ); Thu, 16 Jun 2016 14:11:49 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:966:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:2689:2828:2910:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3870:3872:3873:3874:4321:4385:5007:7903:7904:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12296:12517:12519:12740:13069:13161:13229:13311:13357:13439:13894:14659:21080:30054:30056:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: ball31_66d1d8273a943 X-Filterd-Recvd-Size: 2064 Message-ID: <1466100705.19647.47.camel@perches.com> Subject: Re: [PATCH 6/8] net: gianfar: fix old-style declaration From: Joe Perches To: Sergei Shtylyov , Arnd Bergmann , netdev@vger.kernel.org Cc: "David S. Miller" , Yangbo Lu , linux-kernel@vger.kernel.org Date: Thu, 16 Jun 2016 11:11:45 -0700 In-Reply-To: <0d9320db-ae2c-03a2-eb20-e527a69c356b@cogentembedded.com> References: <20160616135020.3154461-1-arnd@arndb.de> <20160616135245.3198419-1-arnd@arndb.de> <20160616135245.3198419-6-arnd@arndb.de> <0d9320db-ae2c-03a2-eb20-e527a69c356b@cogentembedded.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2016-06-16 at 21:02 +0300, Sergei Shtylyov wrote: > On 06/16/2016 04:52 PM, Arnd Bergmann wrote: > > Modern C standards expect the '__inline__' keyword to come before the return > > type in a declaration, and we get a warning for this with "make W=1": [] > > diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c [] > > @@ -2275,7 +2275,7 @@ static inline void gfar_tx_checksum(struct sk_buff *skb, struct txfcb *fcb, > >   fcb->flags = flags; > >  } > > > > -void inline gfar_tx_vlan(struct sk_buff *skb, struct txfcb *fcb) > > +static inline void gfar_tx_vlan(struct sk_buff *skb, struct txfcb *fcb) >     You don't mention making it *static*. Though the function can be *static*  > indeed... the current policy also forbids *inline* in the *.c files, leaving  > the judgement to gcc. While mostly true, (__always_inline vs inline vs nothing), there are many inline uses in this file that could be removed in a separate patch rather than removing just this one.