All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: kernel bug in "Drop WIMG in favour of new constants"?
Date: Fri, 17 Jun 2016 08:30:36 +1000	[thread overview]
Message-ID: <1466116236.24271.26.camel@kernel.crashing.org> (raw)
In-Reply-To: <87twgt8ask.fsf@skywalker.in.ibm.com>

On Thu, 2016-06-16 at 20:01 +0530, Aneesh Kumar K.V wrote:
> The pHyp part of the comment was added by you in 
> 3c726f8dee6f55e96475574e9f645327e461884c ([PATCH] ppc64: support 64k
> page) really an old commit. I also remember we having the discussion and
> concluding that it should be safe to assume that we can always enable
> memory coherence. Should we do the below patch of get Qemu fixed up ?
> like below
> 
> -        if ((ptel & (HPTE64_R_W | HPTE64_R_I | HPTE64_R_M)) != HPTE64_R_I) {
> +        wimg_flags = (ptel & (HPTE64_R_W | HPTE64_R_I | HPTE64_R_M));
> +
> +        if (wimg_flags != HPTE64_R_I && wimg_flags != (HPTE64_R_I | HPTE64_R_M)) {
>              return H_PARAMETER;
>          }

Makes sense.

Cheers,
Ben.

  reply	other threads:[~2016-06-16 22:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-16  4:33 kernel bug in "Drop WIMG in favour of new constants"? Darrick J. Wong
2016-06-16  5:23 ` Michael Ellerman
2016-06-16  5:57   ` Darrick J. Wong
2016-06-16 10:07     ` Aneesh Kumar K.V
2016-06-16 10:46       ` Aneesh Kumar K.V
2016-06-16 10:52         ` Aneesh Kumar K.V
2016-06-16 12:05           ` Benjamin Herrenschmidt
2016-06-16 14:45             ` Aneesh Kumar K.V
2016-06-16 14:31           ` Aneesh Kumar K.V
2016-06-16 22:30             ` Benjamin Herrenschmidt [this message]
2016-06-17  1:49             ` Darrick J. Wong
2016-06-16 16:23         ` Darrick J. Wong
2016-06-16  5:28 ` Balbir Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466116236.24271.26.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=darrick.wong@oracle.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.