diff for duplicates of <1466117661-22075-3-git-send-email-mcgrof@kernel.org> diff --git a/a/1.txt b/N1/1.txt index f4b49a4..66f8339 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -34,8 +34,8 @@ request_firmware*() API on the initial probe or init routine. There are 4 offenders at this time: -mcgrof at ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci -mcgrof at ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report +mcgrof@ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci +mcgrof@ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report drivers/fmc/fmc-fakedev.c: ERROR: driver call request firmware call on its init routine on line 321. drivers/fmc/fmc-write-eeprom.c: ERROR: driver call request firmware call on its probe routine on line 136. @@ -53,7 +53,7 @@ o This now supports iteration, this extends our coverage on the report o Update documentation and commit log to accept the fate of not being able to remove the usermode helper. -[0] https://lkml.kernel.org/r/1440811107-861-1-git-send-email-mcgrof at do-not-panic.com +[0] https://lkml.kernel.org/r/1440811107-861-1-git-send-email-mcgrof@do-not-panic.com Cc: Alessandro Rubini <rubini@gnudd.com> Cc: Kevin Cernekee <cernekee@gmail.com> @@ -69,15 +69,15 @@ Cc: Gilles Muller <Gilles.Muller@lip6.fr> Cc: Nicolas Palix <nicolas.palix@imag.fr> Cc: Thierry Martinez <martinez@nsup.org> Cc: Michal Marek <mmarek@suse.com> -Cc: cocci at systeme.lip6.fr +Cc: cocci@systeme.lip6.fr Cc: Alessandro Rubini <rubini@gnudd.com> Cc: Kevin Cernekee <cernekee@gmail.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> -Cc: linux-serial at vger.kernel.org -Cc: linux-doc at vger.kernel.org -Cc: linux-serial at vger.kernel.org -Cc: linuxppc-dev at lists.ozlabs.org +Cc: linux-serial@vger.kernel.org +Cc: linux-doc@vger.kernel.org +Cc: linux-serial@vger.kernel.org +Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- Documentation/firmware_class/README | 20 ++++ @@ -156,7 +156,7 @@ index 000000000000..cf180c59e042 + +// ------------------------------------------------------------------------- + -+ at initialize:python@ ++@initialize:python@ +@@ + +seen = set() @@ -197,19 +197,19 @@ index 000000000000..cf180c59e042 + .probe_op = drv_probe, +}; + -+ at hascall depends on !after_start && defines_module_init@ ++@hascall depends on !after_start && defines_module_init@ +position p; +@@ + +( -+request_firmware at p(...) ++request_firmware@p(...) +| -+request_firmware_nowait at p(...) ++request_firmware_nowait@p(...) +| -+request_firmware_direct at p(...) ++request_firmware_direct@p(...) +) + -+ at script:python@ ++@script:python@ +init << defines_module_init.init; +p << hascall.p; +@@ @@ -218,7 +218,7 @@ index 000000000000..cf180c59e042 + print_err("init", p[0].file, int(p[0].line)) + cocci.include_match(False) + -+ at script:python@ ++@script:python@ +drv_probe << has_probe.drv_probe; +p << hascall.p; +@@ @@ -227,20 +227,20 @@ index 000000000000..cf180c59e042 + print_err("probe", p[0].file, int(p[0].line)) + cocci.include_match(False) + -+ at script:python@ ++@script:python@ +p << hascall.p; +@@ + +add_if_not_present(p[0].current_element, p[0].file, p[0].line) + -+ at hasrecall depends on after_start@ ++@hasrecall depends on after_start@ +position p; +identifier virtual.fn; +@@ + -+fn at p(...) ++fn@p(...) + -+ at script:python@ ++@script:python@ +init << defines_module_init.init; +p << hasrecall.p; +starter << virtual.starter; @@ -250,7 +250,7 @@ index 000000000000..cf180c59e042 + print_err("init", p[0].file, int(starter)) + cocci.include_match(False) + -+ at script:python@ ++@script:python@ +drv_probe << has_probe.drv_probe; +p << hasrecall.p; +starter << virtual.starter; diff --git a/a/content_digest b/N1/content_digest index 2888c11..a2360e2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,45 @@ "ref\01466117661-22075-1-git-send-email-mcgrof@kernel.org\0" - "From\0mcgrof@kernel.org (Luis R. Rodriguez)\0" - "Subject\0[Cocci] [PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe\0" + "From\0Luis R. Rodriguez <mcgrof@kernel.org>\0" + "Subject\0[PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe\0" "Date\0Thu, 16 Jun 2016 15:54:18 -0700\0" - "To\0cocci@systeme.lip6.fr\0" + "To\0ming.lei@canonical.com" + akpm@linux-foundation.org + mmarek@suse.com + " gregkh@linuxfoundation.org\0" + "Cc\0linux-kernel@vger.kernel.org" + markivx@codeaurora.org + stephen.boyd@linaro.org + zohar@linux.vnet.ibm.com + broonie@kernel.org + tiwai@suse.de + johannes@sipsolutions.net + chunkeey@googlemail.com + hauke@hauke-m.de + jwboyer@fedoraproject.org + dmitry.torokhov@gmail.com + dwmw2@infradead.org + jslaby@suse.com + torvalds@linux-foundation.org + luto@amacapital.net + fengguang.wu@intel.com + rpurdie@rpsys.net + j.anaszewski@samsung.com + Abhay_Salunke@dell.com + Julia.Lawall@lip6.fr + Gilles.Muller@lip6.fr + nicolas.palix@imag.fr + teg@jklm.no + dhowells@redhat.com + Luis R. Rodriguez <mcgrof@kernel.org> + Alessandro Rubini <rubini@gnudd.com> + Kevin Cernekee <cernekee@gmail.com> + Daniel Vetter <daniel.vetter@ffwll.ch> + Kees Cook <keescook@chromium.org> + Jonathan Corbet <corbet@lwn.net> + Thierry Martinez <martinez@nsup.org> + cocci@systeme.lip6.fr + linux-serial@vger.kernel.org + " linux-doc@vge\0" "\00:1\0" "b\0" "Thou shalt not make firmware calls early on init or probe.\n" @@ -41,8 +78,8 @@ "\n" "There are 4 offenders at this time:\n" "\n" - "mcgrof at ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci\n" - "mcgrof at ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report\n" + "mcgrof@ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci\n" + "mcgrof@ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report\n" "\n" "drivers/fmc/fmc-fakedev.c: ERROR: driver call request firmware call on its init routine on line 321.\n" "drivers/fmc/fmc-write-eeprom.c: ERROR: driver call request firmware call on its probe routine on line 136.\n" @@ -60,7 +97,7 @@ "o Update documentation and commit log to accept the fate of not being\n" " able to remove the usermode helper.\n" "\n" - "[0] https://lkml.kernel.org/r/1440811107-861-1-git-send-email-mcgrof at do-not-panic.com\n" + "[0] https://lkml.kernel.org/r/1440811107-861-1-git-send-email-mcgrof@do-not-panic.com\n" "\n" "Cc: Alessandro Rubini <rubini@gnudd.com>\n" "Cc: Kevin Cernekee <cernekee@gmail.com>\n" @@ -76,15 +113,15 @@ "Cc: Nicolas Palix <nicolas.palix@imag.fr>\n" "Cc: Thierry Martinez <martinez@nsup.org>\n" "Cc: Michal Marek <mmarek@suse.com>\n" - "Cc: cocci at systeme.lip6.fr\n" + "Cc: cocci@systeme.lip6.fr\n" "Cc: Alessandro Rubini <rubini@gnudd.com>\n" "Cc: Kevin Cernekee <cernekee@gmail.com>\n" "Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n" "Cc: Jiri Slaby <jslaby@suse.com>\n" - "Cc: linux-serial at vger.kernel.org\n" - "Cc: linux-doc at vger.kernel.org\n" - "Cc: linux-serial at vger.kernel.org\n" - "Cc: linuxppc-dev at lists.ozlabs.org\n" + "Cc: linux-serial@vger.kernel.org\n" + "Cc: linux-doc@vger.kernel.org\n" + "Cc: linux-serial@vger.kernel.org\n" + "Cc: linuxppc-dev@lists.ozlabs.org\n" "Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>\n" "---\n" " Documentation/firmware_class/README | 20 ++++\n" @@ -163,7 +200,7 @@ "+\n" "+// -------------------------------------------------------------------------\n" "+\n" - "+ at initialize:python@\n" + "+@initialize:python@\n" "+@@\n" "+\n" "+seen = set()\n" @@ -204,19 +241,19 @@ "+\t.probe_op = drv_probe,\n" "+};\n" "+\n" - "+ at hascall depends on !after_start && defines_module_init@\n" + "+@hascall depends on !after_start && defines_module_init@\n" "+position p;\n" "+@@\n" "+\n" "+(\n" - "+request_firmware at p(...)\n" + "+request_firmware@p(...)\n" "+|\n" - "+request_firmware_nowait at p(...)\n" + "+request_firmware_nowait@p(...)\n" "+|\n" - "+request_firmware_direct at p(...)\n" + "+request_firmware_direct@p(...)\n" "+)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+init << defines_module_init.init;\n" "+p << hascall.p;\n" "+@@\n" @@ -225,7 +262,7 @@ "+ print_err(\"init\", p[0].file, int(p[0].line))\n" "+ cocci.include_match(False)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+drv_probe << has_probe.drv_probe;\n" "+p << hascall.p;\n" "+@@\n" @@ -234,20 +271,20 @@ "+ print_err(\"probe\", p[0].file, int(p[0].line))\n" "+ cocci.include_match(False)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+p << hascall.p;\n" "+@@\n" "+\n" "+add_if_not_present(p[0].current_element, p[0].file, p[0].line)\n" "+\n" - "+ at hasrecall depends on after_start@\n" + "+@hasrecall depends on after_start@\n" "+position p;\n" "+identifier virtual.fn;\n" "+@@\n" "+\n" - "+fn at p(...)\n" + "+fn@p(...)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+init << defines_module_init.init;\n" "+p << hasrecall.p;\n" "+starter << virtual.starter;\n" @@ -257,7 +294,7 @@ "+ print_err(\"init\", p[0].file, int(starter))\n" "+ cocci.include_match(False)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+drv_probe << has_probe.drv_probe;\n" "+p << hasrecall.p;\n" "+starter << virtual.starter;\n" @@ -276,4 +313,4 @@ "-- \n" 2.8.2 -f91fdc29d195287f52340e29a99e1499bae6753c2d85259ef9ca98042257843b +966b76ba75e4b57361ae3bc96016207fe45ae21badb7a3c7b7f41e8dc07001cf
diff --git a/a/1.txt b/N2/1.txt index f4b49a4..66f8339 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -34,8 +34,8 @@ request_firmware*() API on the initial probe or init routine. There are 4 offenders at this time: -mcgrof at ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci -mcgrof at ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report +mcgrof@ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci +mcgrof@ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report drivers/fmc/fmc-fakedev.c: ERROR: driver call request firmware call on its init routine on line 321. drivers/fmc/fmc-write-eeprom.c: ERROR: driver call request firmware call on its probe routine on line 136. @@ -53,7 +53,7 @@ o This now supports iteration, this extends our coverage on the report o Update documentation and commit log to accept the fate of not being able to remove the usermode helper. -[0] https://lkml.kernel.org/r/1440811107-861-1-git-send-email-mcgrof at do-not-panic.com +[0] https://lkml.kernel.org/r/1440811107-861-1-git-send-email-mcgrof@do-not-panic.com Cc: Alessandro Rubini <rubini@gnudd.com> Cc: Kevin Cernekee <cernekee@gmail.com> @@ -69,15 +69,15 @@ Cc: Gilles Muller <Gilles.Muller@lip6.fr> Cc: Nicolas Palix <nicolas.palix@imag.fr> Cc: Thierry Martinez <martinez@nsup.org> Cc: Michal Marek <mmarek@suse.com> -Cc: cocci at systeme.lip6.fr +Cc: cocci@systeme.lip6.fr Cc: Alessandro Rubini <rubini@gnudd.com> Cc: Kevin Cernekee <cernekee@gmail.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Jiri Slaby <jslaby@suse.com> -Cc: linux-serial at vger.kernel.org -Cc: linux-doc at vger.kernel.org -Cc: linux-serial at vger.kernel.org -Cc: linuxppc-dev at lists.ozlabs.org +Cc: linux-serial@vger.kernel.org +Cc: linux-doc@vger.kernel.org +Cc: linux-serial@vger.kernel.org +Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- Documentation/firmware_class/README | 20 ++++ @@ -156,7 +156,7 @@ index 000000000000..cf180c59e042 + +// ------------------------------------------------------------------------- + -+ at initialize:python@ ++@initialize:python@ +@@ + +seen = set() @@ -197,19 +197,19 @@ index 000000000000..cf180c59e042 + .probe_op = drv_probe, +}; + -+ at hascall depends on !after_start && defines_module_init@ ++@hascall depends on !after_start && defines_module_init@ +position p; +@@ + +( -+request_firmware at p(...) ++request_firmware@p(...) +| -+request_firmware_nowait at p(...) ++request_firmware_nowait@p(...) +| -+request_firmware_direct at p(...) ++request_firmware_direct@p(...) +) + -+ at script:python@ ++@script:python@ +init << defines_module_init.init; +p << hascall.p; +@@ @@ -218,7 +218,7 @@ index 000000000000..cf180c59e042 + print_err("init", p[0].file, int(p[0].line)) + cocci.include_match(False) + -+ at script:python@ ++@script:python@ +drv_probe << has_probe.drv_probe; +p << hascall.p; +@@ @@ -227,20 +227,20 @@ index 000000000000..cf180c59e042 + print_err("probe", p[0].file, int(p[0].line)) + cocci.include_match(False) + -+ at script:python@ ++@script:python@ +p << hascall.p; +@@ + +add_if_not_present(p[0].current_element, p[0].file, p[0].line) + -+ at hasrecall depends on after_start@ ++@hasrecall depends on after_start@ +position p; +identifier virtual.fn; +@@ + -+fn at p(...) ++fn@p(...) + -+ at script:python@ ++@script:python@ +init << defines_module_init.init; +p << hasrecall.p; +starter << virtual.starter; @@ -250,7 +250,7 @@ index 000000000000..cf180c59e042 + print_err("init", p[0].file, int(starter)) + cocci.include_match(False) + -+ at script:python@ ++@script:python@ +drv_probe << has_probe.drv_probe; +p << hasrecall.p; +starter << virtual.starter; diff --git a/a/content_digest b/N2/content_digest index 2888c11..2f1328b 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,8 +1,46 @@ "ref\01466117661-22075-1-git-send-email-mcgrof@kernel.org\0" - "From\0mcgrof@kernel.org (Luis R. Rodriguez)\0" - "Subject\0[Cocci] [PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe\0" + "From\0Luis R. Rodriguez <mcgrof@kernel.org>\0" + "Subject\0[PATCH v2 2/5] firmware: annotate thou shalt not request fw on init or probe\0" "Date\0Thu, 16 Jun 2016 15:54:18 -0700\0" - "To\0cocci@systeme.lip6.fr\0" + "To\0ming.lei@canonical.com" + akpm@linux-foundation.org + mmarek@suse.com + " gregkh@linuxfoundation.org\0" + "Cc\0linux-kernel@vger.kernel.org" + markivx@codeaurora.org + stephen.boyd@linaro.org + zohar@linux.vnet.ibm.com + broonie@kernel.org + tiwai@suse.de + johannes@sipsolutions.net + chunkeey@googlemail.com + hauke@hauke-m.de + jwboyer@fedoraproject.org + dmitry.torokhov@gmail.com + dwmw2@infradead.org + jslaby@suse.com + torvalds@linux-foundation.org + luto@amacapital.net + fengguang.wu@intel.com + rpurdie@rpsys.net + j.anaszewski@samsung.com + Abhay_Salunke@dell.com + Julia.Lawall@lip6.fr + Gilles.Muller@lip6.fr + nicolas.palix@imag.fr + teg@jklm.no + dhowells@redhat.com + Luis R. Rodriguez <mcgrof@kernel.org> + Alessandro Rubini <rubini@gnudd.com> + Kevin Cernekee <cernekee@gmail.com> + Daniel Vetter <daniel.vetter@ffwll.ch> + Kees Cook <keescook@chromium.org> + Jonathan Corbet <corbet@lwn.net> + Thierry Martinez <martinez@nsup.org> + cocci@systeme.lip6.fr + linux-serial@vger.kernel.org + linux-doc@vger.kernel.org + " linuxppc-dev@lists.ozlabs.org\0" "\00:1\0" "b\0" "Thou shalt not make firmware calls early on init or probe.\n" @@ -41,8 +79,8 @@ "\n" "There are 4 offenders at this time:\n" "\n" - "mcgrof at ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci\n" - "mcgrof at ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report\n" + "mcgrof@ergon ~/linux-next (git::20160609)$ export COCCI=scripts/coccinelle/api/request_firmware.cocci\n" + "mcgrof@ergon ~/linux-next (git::20160609)$ make coccicheck MODE=report\n" "\n" "drivers/fmc/fmc-fakedev.c: ERROR: driver call request firmware call on its init routine on line 321.\n" "drivers/fmc/fmc-write-eeprom.c: ERROR: driver call request firmware call on its probe routine on line 136.\n" @@ -60,7 +98,7 @@ "o Update documentation and commit log to accept the fate of not being\n" " able to remove the usermode helper.\n" "\n" - "[0] https://lkml.kernel.org/r/1440811107-861-1-git-send-email-mcgrof at do-not-panic.com\n" + "[0] https://lkml.kernel.org/r/1440811107-861-1-git-send-email-mcgrof@do-not-panic.com\n" "\n" "Cc: Alessandro Rubini <rubini@gnudd.com>\n" "Cc: Kevin Cernekee <cernekee@gmail.com>\n" @@ -76,15 +114,15 @@ "Cc: Nicolas Palix <nicolas.palix@imag.fr>\n" "Cc: Thierry Martinez <martinez@nsup.org>\n" "Cc: Michal Marek <mmarek@suse.com>\n" - "Cc: cocci at systeme.lip6.fr\n" + "Cc: cocci@systeme.lip6.fr\n" "Cc: Alessandro Rubini <rubini@gnudd.com>\n" "Cc: Kevin Cernekee <cernekee@gmail.com>\n" "Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>\n" "Cc: Jiri Slaby <jslaby@suse.com>\n" - "Cc: linux-serial at vger.kernel.org\n" - "Cc: linux-doc at vger.kernel.org\n" - "Cc: linux-serial at vger.kernel.org\n" - "Cc: linuxppc-dev at lists.ozlabs.org\n" + "Cc: linux-serial@vger.kernel.org\n" + "Cc: linux-doc@vger.kernel.org\n" + "Cc: linux-serial@vger.kernel.org\n" + "Cc: linuxppc-dev@lists.ozlabs.org\n" "Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>\n" "---\n" " Documentation/firmware_class/README | 20 ++++\n" @@ -163,7 +201,7 @@ "+\n" "+// -------------------------------------------------------------------------\n" "+\n" - "+ at initialize:python@\n" + "+@initialize:python@\n" "+@@\n" "+\n" "+seen = set()\n" @@ -204,19 +242,19 @@ "+\t.probe_op = drv_probe,\n" "+};\n" "+\n" - "+ at hascall depends on !after_start && defines_module_init@\n" + "+@hascall depends on !after_start && defines_module_init@\n" "+position p;\n" "+@@\n" "+\n" "+(\n" - "+request_firmware at p(...)\n" + "+request_firmware@p(...)\n" "+|\n" - "+request_firmware_nowait at p(...)\n" + "+request_firmware_nowait@p(...)\n" "+|\n" - "+request_firmware_direct at p(...)\n" + "+request_firmware_direct@p(...)\n" "+)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+init << defines_module_init.init;\n" "+p << hascall.p;\n" "+@@\n" @@ -225,7 +263,7 @@ "+ print_err(\"init\", p[0].file, int(p[0].line))\n" "+ cocci.include_match(False)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+drv_probe << has_probe.drv_probe;\n" "+p << hascall.p;\n" "+@@\n" @@ -234,20 +272,20 @@ "+ print_err(\"probe\", p[0].file, int(p[0].line))\n" "+ cocci.include_match(False)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+p << hascall.p;\n" "+@@\n" "+\n" "+add_if_not_present(p[0].current_element, p[0].file, p[0].line)\n" "+\n" - "+ at hasrecall depends on after_start@\n" + "+@hasrecall depends on after_start@\n" "+position p;\n" "+identifier virtual.fn;\n" "+@@\n" "+\n" - "+fn at p(...)\n" + "+fn@p(...)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+init << defines_module_init.init;\n" "+p << hasrecall.p;\n" "+starter << virtual.starter;\n" @@ -257,7 +295,7 @@ "+ print_err(\"init\", p[0].file, int(starter))\n" "+ cocci.include_match(False)\n" "+\n" - "+ at script:python@\n" + "+@script:python@\n" "+drv_probe << has_probe.drv_probe;\n" "+p << hasrecall.p;\n" "+starter << virtual.starter;\n" @@ -276,4 +314,4 @@ "-- \n" 2.8.2 -f91fdc29d195287f52340e29a99e1499bae6753c2d85259ef9ca98042257843b +13c468442ae418f43ee046a1de7ef9f8bcd8fa289250ba1f49c20e483b04a14c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.