From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755548AbcFQTzA (ORCPT ); Fri, 17 Jun 2016 15:55:00 -0400 Received: from smtprelay0183.hostedemail.com ([216.40.44.183]:53992 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753608AbcFQTy7 (ORCPT ); Fri, 17 Jun 2016 15:54:59 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::,RULES_HIT:41:355:379:541:599:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2828:2919:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:6248:7875:7904:9010:10004:10400:10848:11232:11658:11783:11914:12048:12517:12519:12740:13069:13311:13357:13439:13894:14659:14721:21080:21324:21433:30012:30029:30030:30054:30060:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: room19_2b2eae0662344 X-Filterd-Recvd-Size: 1858 Message-ID: <1466193295.19647.118.camel@perches.com> Subject: Re: [PATCH v2] lib: Make strreplace prototype compatible with C++ From: Joe Perches To: 57644395.9010505@infradead.org, Randy Dunlap , Linus Torvalds , Matt Ullman Cc: linux-kernel@vger.kernel.org Date: Fri, 17 Jun 2016 12:54:55 -0700 In-Reply-To: <20160617193856.GA25433@staticfox.net> References: <20160617172412.9644-1-staticfox@staticfox.net> <57644395.9010505@infradead.org> <20160617193856.GA25433@staticfox.net> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (Matt, you've got an unusual reply-to header) On Fri, 2016-06-17 at 15:38 -0400, Matt Ullman wrote: > On Fri, Jun 17, 2016 at 11:38:13AM -0700, Randy Dunlap wrote: > > I didn't see and could not find any reply to v1.  Who is that comment > > addressed to?  Linus? > Yes, this was addressed to Linus. He CC'd the mailing list, but I could not > find it either. Here is what he wrote: > > > > Please only change the prototype, not the function. Might as well remove > > the argument names in the prototype. > > > > Let's not make the C code uglier for no reason. The fact that C++ screwed > > up and thought that "new" can't be used as a variable name is no reason not > > to do it in C code. > > > > Similarly, we don't make C code use the insane C++ pointer caring rules. > > > >    Linus > -- Matt Ullman I think kernel-doc is useful and maybe from/to or find/replace could be used instead of old/new