From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Fri, 17 Jun 2016 16:06:55 -0700 Message-ID: <1466204815.2199.2.camel@HansenPartnership.com> References: <1464638381.2240.3.camel@HansenPartnership.com> <871t4ibr7k.fsf@intel.com> <1464701638.2234.1.camel@HansenPartnership.com> <87mvmp9z03.fsf@intel.com> <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87vb18uef2.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula , Daniel Vetter Cc: intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAyMDE2LTA2LTE3IGF0IDE2OjM0ICswMzAwLCBKYW5pIE5pa3VsYSB3cm90ZToKPiBP biBGcmksIDE3IEp1biAyMDE2LCBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+IHdyb3Rl Ogo+ID4gT24gVGh1LCBKdW4gMTYsIDIwMTYgYXQgMDM6NDI6MTJQTSAtMDcwMCwgSmFtZXMgQm90 dG9tbGV5IHdyb3RlOgo+ID4gPiBPbiBUaHUsIDIwMTYtMDYtMTYgYXQgMTQ6MjkgLTA3MDAsIEph bWVzIEJvdHRvbWxleSB3cm90ZToKPiA+ID4gPiBPbiBUaHUsIDIwMTYtMDYtMTYgYXQgMjM6MjQg KzAyMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiA+ID4gPiBJIGd1ZXNzIHdlJ2xsIG5lZWQg dGhlIGJpc2VjdCBvbiB0aGlzIG9uZSB0byBtYWtlIHByb2dyZXNzLgo+ID4gPiA+IAo+ID4gPiA+ IFNpZ2gsIEkgd2FzIGFmcmFpZCB0aGF0IG1pZ2h0IGJlIHRoZSBuZXh0IHN0ZXAuCj4gPiA+IAo+ ID4gPiBPSywgSSBoYXZlIGEgY3VyaW91cyBkYXRhIHBvaW50LiAgSSBhc3N1bWVkIHRoZSBwcm9i bGVtIHdvdWxkIGJlCj4gPiA+IHNvbWV3aGVyZSBpbiB0aGUgZHJtIHVwZGF0ZSwgc28gSSBzdGFy dGVkIGJpc2VjdGluZyB0aGF0IGF0IHRoZQo+ID4gPiB0b3AuIAo+ID4gPiAgSG93ZXZlciwgdGhl IHRvcCBtb3N0IGNvbW1pdDoKPiA+ID4gCj4gPiA+IGNvbW1pdCAxZDZkYTg3YTMyNDFkZWIxM2Qw NzNjNDEyNWQxOWVkMGU1YTBjNjJjCj4gPiA+IE1lcmdlOiAxZjQwYzQ5IGEzOWVkNjgKPiA+ID4g QXV0aG9yOiBMaW51cyBUb3J2YWxkcyA8dG9ydmFsZHNAbGludXgtZm91bmRhdGlvbi5vcmc+Cj4g PiA+IERhdGU6ICAgTW9uIE1heSAyMyAxMTo0ODo0OCAyMDE2IC0wNzAwCj4gPiA+IAo+ID4gPiAg ICAgTWVyZ2UgYnJhbmNoICdkcm0tbmV4dCcgb2YKPiA+ID4gZ2l0Oi8vcGVvcGxlLmZyZWVkZXNr dG9wLm9yZy9+YWlybGllZC9saW51eAo+ID4gPiAKPiA+ID4gSXNuJ3QgYWN0dWFsbHkgYmFkLiAg VGhlcmUncyBubyBmbGlja2VyIGhlcmUsIHNvIHdoYXRldmVyIGNhdXNlZAo+ID4gPiB0aGUKPiA+ ID4gcHJvYmxlbSBjYW1lIGZyb20gc29tZSB1cGRhdGUgYWZ0ZXIgdGhpcy4KPiA+IAo+ID4gVGhl cmUgd2FzIGEgZml4ZXMgcHVsbCBhZnRlciB0aGlzLiBNaWdodCBiZSB3b3J0aCBpdCB0byByZXN0 cmljdCB0bwo+ID4ganVzdAo+ID4gdGhlIGk5MTUgY2hhbmdlcywgd2hpY2ggYXJlIGp1c3QKPiA+ IDViNGZkNWIxMTExYjEyMzBjZDAzNy4uMTU3ZDJjN2ZhZDA4NjMyMjIKPiA+IAo+ID4gTG9va2lu ZyBhdCB0aG9zZSBub3RoaW5nIHNlZW1zIHRvIHN0aWNrIG91dCB3aGljaCBtaWdodCBleHBsYWlu Cj4gPiB3aGF0J3MKPiA+IGhhcHBlbmluZyBmb3IgeW91LgoKT0ssIHNvIGp1c3Qgb24gdGhlIGZp cm13YXJlLCB0aGUgc3lzdGVtIHNlZW1zIGxlc3MgZmxpY2tlcnkgd2l0aCB0aGUKbmV3IDEuNC4z IFVFRkksIHNvIEknbSBzdGFydGluZyB0byB0aGluayBpdCBpcyBhIFNreWxha2UgZXJyYXRhIGlz c3VlLiAKIFRoZSBmbGlja2VyIGlzbid0IGdvbmUgZm9yIGdvb2QsIGJ1dCBzZWVtcyB0byBiZSBy ZWJvb3QgZGVwZW5kZW50CihpdCdzIHRoZXJlIGluIHNvbWUgYm9vdHMsIGJ1dCBnb25lIG9uIGEg cmVib290KS4KCj4gVGhpcyBzaG91bGQgYmUgZWFzeSBlbm91Z2ggdG8gdHJ5IGJlZm9yZSBiaXNl Y3Rpbmc6Cj4gaHR0cDovL3BhdGNod29yay5mcmVlZGVza3RvcC5vcmcvcGF0Y2gvbXNnaWQvMTQ2 NjE2MjA4MS0xMjA0Mi0xLWdpdC1zCj4gZW5kLWVtYWlsLW1pa2Eua2Fob2xhQGludGVsLmNvbQoK QXBwbHlpbmcgdGhpcyBkaWRuJ3Qgc2VlbSB0byBtYWtlIGEgZGlmZmVyZW5jZTogc3RpbGwgdGhl cmUgb24gc29tZSBhbmQKZ29uZSBvbiBvdGhlciByZWJvb3RzLgoKSmFtZXMKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBs aXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372AbcFQXHA (ORCPT ); Fri, 17 Jun 2016 19:07:00 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:51614 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbcFQXG7 (ORCPT ); Fri, 17 Jun 2016 19:06:59 -0400 Message-ID: <1466204815.2199.2.camel@HansenPartnership.com> Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window From: James Bottomley To: Jani Nikula , Daniel Vetter Cc: intel-gfx , dri-devel , linux-kernel , Rodrigo Vivi Date: Fri, 17 Jun 2016 16:06:55 -0700 In-Reply-To: <87vb18uef2.fsf@intel.com> References: <1464638381.2240.3.camel@HansenPartnership.com> <871t4ibr7k.fsf@intel.com> <1464701638.2234.1.camel@HansenPartnership.com> <87mvmp9z03.fsf@intel.com> <1466111747.2311.1.camel@HansenPartnership.com> <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.5 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2016-06-17 at 16:34 +0300, Jani Nikula wrote: > On Fri, 17 Jun 2016, Daniel Vetter wrote: > > On Thu, Jun 16, 2016 at 03:42:12PM -0700, James Bottomley wrote: > > > On Thu, 2016-06-16 at 14:29 -0700, James Bottomley wrote: > > > > On Thu, 2016-06-16 at 23:24 +0200, Daniel Vetter wrote: > > > > > I guess we'll need the bisect on this one to make progress. > > > > > > > > Sigh, I was afraid that might be the next step. > > > > > > OK, I have a curious data point. I assumed the problem would be > > > somewhere in the drm update, so I started bisecting that at the > > > top. > > > However, the top most commit: > > > > > > commit 1d6da87a3241deb13d073c4125d19ed0e5a0c62c > > > Merge: 1f40c49 a39ed68 > > > Author: Linus Torvalds > > > Date: Mon May 23 11:48:48 2016 -0700 > > > > > > Merge branch 'drm-next' of > > > git://people.freedesktop.org/~airlied/linux > > > > > > Isn't actually bad. There's no flicker here, so whatever caused > > > the > > > problem came from some update after this. > > > > There was a fixes pull after this. Might be worth it to restrict to > > just > > the i915 changes, which are just > > 5b4fd5b1111b1230cd037..157d2c7fad0863222 > > > > Looking at those nothing seems to stick out which might explain > > what's > > happening for you. OK, so just on the firmware, the system seems less flickery with the new 1.4.3 UEFI, so I'm starting to think it is a Skylake errata issue. The flicker isn't gone for good, but seems to be reboot dependent (it's there in some boots, but gone on a reboot). > This should be easy enough to try before bisecting: > http://patchwork.freedesktop.org/patch/msgid/1466162081-12042-1-git-s > end-email-mika.kahola@intel.com Applying this didn't seem to make a difference: still there on some and gone on other reboots. James